8000 gh-121637: Syntax error for optimized-away incorrect await by JelleZijlstra · Pull Request #121656 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121637: Syntax error for optimized-away incorrect await #121656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 22, 2024
Merged

gh-121637: Syntax error for optimized-away incorrect await #121656

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f8395cc
Fix await itself
JelleZijlstra Jul 13, 2024
8160c6c
fix typo
JelleZijlstra Jul 13, 2024
1a39f45
more tests
JelleZijlstra Jul 13, 2024
9a7ce67
News, more fixes
JelleZijlstra Jul 13, 2024
e226b56
Apply suggestions from code review
JelleZijlstra Jul 13, 2024
07d5488
not not no but no
JelleZijlstra Jul 13, 2024
42fef70
Merge branch 'main' into toplevelawait
JelleZijlstra Jul 16, 2024
5806514
Merge remote-tracking branch 'upstream/main' into toplevelawait
JelleZijlstra Jul 22, 2024
456ea04
Code review tweaks
JelleZijlstra Jul 22, 2024
e9c25cd
Update Lib/test/test_builtin.py
JelleZijlstra Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
not not no but no
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Jul 13, 2024
commit 07d5488c0238ab9344c4b47de6609b8f1d819d43
2 changes: 1 addition & 1 deletion Python/symtable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2296,7 +2296,7 @@ symtable_visit_expr(struct symtable *st, expr_ty e)
st->st_cur->ste_type == FunctionBlock &&
st->st_cur->ste_coroutine
);
if (!is_async_def && st->st_cur->ste_comprehension != NoComprehension) {
if (!is_async_def && st->st_cur->ste_comprehension == NoComprehension) {
PyErr_SetString(PyExc_SyntaxError,
"'await' outside async function");
SET_ERROR_LOCATION(st->st_filename, LOCATION(e));
Expand Down
Loading
0