8000 gh-121583: Remove dependency from pystats.h to internal header file by mdboom · Pull Request #121587 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121583: Remove dependency from pystats.h to internal header file #121587

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2024
Merged

gh-121583: Remove dependency from pystats.h to internal header file #121587

merged 3 commits into from
Jul 16, 2024

Conversation

mdboom
Copy link
Contributor
@mdboom mdboom commented Jul 10, 2024 •
edited by bedevere-app bot
Loading

This just uses a fixed number of slots for recording uops stats that is enforced to be big enough.

Alternatively, we could generate the correct number and put it in a public header, but that seems like overkill.

@bedevere-app bedevere-app bot mentioned this pull request Jul 10, 2024
Closed
@mdboom mdboom requested a review from markshannon July 10, 2024 15:03
ZeroIntensity
ZeroIntensity requested changes Jul 10, 2024
View reviewed changes
Copy link
Member
@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should follow PEP 7.

mdboom and others added 2 commits July 10, 2024 11:32
@mdboom @ZeroIntensity
Update Include/cpython/pystats.h
376ba22 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@mdboom @ZeroIntensity
Update Include/cpython/pystats.h
e48b8ca 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
brandtbucher
brandtbucher approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member
@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdboom! I'm going to go ahead and land this.

@brandtbucher brandtbucher self-assigned this Jul 16, 2024
@brandtbucher brandtbucher merged commit f036a46 into python:main Jul 16, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2024
@mdboom @ZeroIntensity @miss-islington
pythonGH-121583: Remove dependency from pystats.h to internal header …
6f5842e 
…file (pythonGH-121587)

(cherry picked from commit f036a46)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jul 16, 2024

GH-121880 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

@brandtbucher brandtbucher

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdboom @brandtbucher @ZeroIntensity
0