10000 gh-121571: Do not use `EnvironmentError` in tests, use `OSError` instead by sobolevn · Pull Request #121572 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121571: Do not use EnvironmentError in tests, use OSError instead #121572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

gh-121571: Do not use EnvironmentError in tests, use OSError instead #121572

merged 1 commit into from
Jul 10, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jul 10, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 10, 2024
@sobolevn sobolevn requested a review from vstinner July 10, 2024 08:47
@sobolevn sobolevn requested a review from gpshead as a code owner July 10, 2024 08:47
@bedevere-app bedevere-app bot mentioned this pull request Jul 10, 2024
Closed
@sobolevn sobolevn changed the title gh-121571: Do not use EnvironmentError, use OSError instead gh-121571: Do not use EnvironmentError in tests, use OSError instead Jul 10, 2024
vstinner
vstinner approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

8000
@sobolevn sobolevn merged commit e282236 into python:main Jul 10, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2024
@sobolevn @miss-islington
pythongh-121571: Do not use EnvironmentError in tests, use `OSError…
d439d6b 
…` instead (pythonGH-121572)

(cherry picked from commit e282236)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Jul 10, 2024

GH-121574 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2024
@sobolevn @miss-islington
pythongh-121571: Do not use EnvironmentError in tests, use `OSError…
7d468c2 
…` instead (pythonGH-121572)

(cherry picked from commit e282236)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Jul 10, 2024

GH-121575 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 10, 2024
sobolevn added a commit that referenced this pull request Jul 10, 2024
@miss-islington @sobolevn
[3.12] gh-121571: Do not use EnvironmentError in tests, use `OSErro…
e47fec0 
…r` instead (GH-121572) (#121575)

gh-121571: Do not use `EnvironmentError` in tests, use `OSError` instead (GH-121572)
(cherry picked from commit e282236)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 10, 2024
@miss-islington @sobolevn
[3.13] gh-121571: Do not use EnvironmentError in tests, use `OSErro…
AAE4
ced3fe8 
…r` instead (GH-121572) (#121574)

gh-121571: Do not use `EnvironmentError` in tests, use `OSError` instead (GH-121572)
(cherry picked from commit e282236)

Co-authored-by: sobolevn <mail@sobolevn.me>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-121571: Do not use EnvironmentError in tests, use `OSError…
38e3a26 
…` instead (python#121572)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-121571: Do not use EnvironmentError in tests, use `OSError…
f0e05ce 
…` instead (python#121572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @vstinner
0