8000 gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c by vstinner · Pull Request #121493 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c #121493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c #121493

merged 1 commit into from
Jul 18, 2024

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

compare_unicode_generic(), compare_unicode_unicode() and compare_generic() are callbacks used by do_lookup(). When enabling assertions, it's not possible to inline these functions.

@bedevere-app bedevere-app bot mentioned this pull request Jul 8, 2024
Closed
@vstinner
Copy link
Member Author
vstinner commented Jul 8, 2024

@DinoV: You added Py_ALWAYS_INLINE in the commit 0990d55 of the PR gh-114629. Can you tell me if my change makes sense and if it can have a negative affect on performance?

cc @methane

methane
methane reviewed Jul 8, 2024
View reviewed changes
@vstinner
pythongh-121266: Remove Py_ALWAYS_INLINE in dictobject.c
cc02eac 
compare_unicode_generic(), compare_unicode_unicode() and
compare_generic() are callbacks used by do_lookup(). When enabling
assertions, it's not possible to inline these functions.
@vstinner vstinner force-pushed the remove_always_inline branch from cd9b693 to cc02eac Compare July 17, 2024 19:54
@vstinner
Copy link
Member Author

@methane: Would you mind to review the rebased PR?

@vstinner vstinner merged commit c5a6b9a into python:main Jul 18, 2024
36 checks passed
@vstinner vstinner deleted the remove_always_inline branch July 18, 2024 06:19
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jul 21, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2024
@vstinner @miss-islington
pythongh-121266: Remove Py_ALWAYS_INLINE in dictobject.c (pythonGH-12…
ad75156 
…1493)

compare_unicode_generic(), compare_unicode_unicode() and
compare_generic() are callbacks used by do_lookup(). When enabling
assertions, it's not possible to inline these functions.
(cherry picked from commit c5a6b9a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Jul 21, 2024

GH-122095 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 21, 2024
vstinner added a commit that referenced this pull request Jul 21, 2024
@miss-islington @vstinner
[3.13] gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c (GH-121493) (…
e458268 
…#122095)

gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c (GH-121493)

compare_unicode_generic(), compare_unicode_unicode() and
compare_generic() are callbacks used by do_lookup(). When enabling
assertions, it's not possible to inline these functions.
(cherry picked from commit c5a6b9a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora 3.13 has failed when building commit e458268.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1403/builds/223) and take a look at the build logs.
  4. Check if the failure is related to this commit (e458268) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1403/builds/223

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_inspect_keeps_globals_from_inspected_module - test.test_pyrepl.test_pyrepl.TestMain.test_inspect_keeps_globals_from_inspected_module

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: FOO= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __name__= not found in output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury left review comments

@methane methane methane approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @bedevere-bot @methane @colesbury
0