10000 gh-121445: C implementation for `fnmatch` by picnixz · Pull Request #121446 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121445: C implementation for fnmatch 10000 #121446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 98 commits into from
Closed

gh-121445: C implementation for fnmatch #121446

wants to merge 98 commits into from

Conversation

picnixz
Copy link
Member
@picnixz picnixz commented Jul 6, 2024 •
edited
Loading
  • Update configure script.
  • C implementation
    • use of lru_cache
    • use of os.path.normcase
    • fnmatch.fnmatch
    • fnmatch.fnmathcase
    • fnmatch.translate
  • Make it work on Windows CI/CD.
  • Add documentation
    • C documentation
    • Python documentation
    • NEWS entry
  • Increase test coverage

@bedevere-app bedevere-app bot mentioned this pull request Jul 6, 2024
Closed
picnixz
picnixz commented Jul 6, 2024
View reviewed changes
@picnixz
Copy link
Member Author
picnixz commented Jul 6, 2024

I forgot that MSVC didn't have an implementation of fnmatch... I'll add a guard for Windows so that it uses the pure Python implementation.

picnixz
picnixz commented Jul 7, 2024
View reviewed changes
@picnixz

This comment was marked as outdated.

Sign in to view
@picnixz

This comment was marked as outdated.

Sign in to view
@picnixz picnixz removed the request for review from markshannon July 20, 2024 10:10
@picnixz picnixz mentioned this pull request Jul 25, 2024
Closed
picnixz added 19 commits July 28, 2024 12:14
@picnixz picnixz mentioned this pull request Aug 20, 2024
Closed
@picnixz
Copy link
Member Author
picnixz commented Aug 23, 2024

See issue for the rationale of closing this PR.

@picnixz picnixz closed this Aug 23, 2024
@picnixz picnixz deleted the fnmatch-c-implementation branch November 30, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @zooba
0