8000 gh-119004: fix a crash in equality testing between `OrderedDict` by picnixz · Pull Request #121329 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-119004: fix a crash in equality testing between OrderedDict #121329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 23, 2024
Merged

gh-119004: fix a crash in equality testing between OrderedDict #121329

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
da396cc
fix a crash in `OrderedDict`
picnixz Jul 3, 2024
6cdabc6
add tests
picnixz Jul 3, 2024
3a374dc
update docs
picnixz Jul 3, 2024
5c7bccc
blurb
picnixz Jul 3, 2024
24f0807
update docs
picnixz Jul 4, 2024
2f29ca6
improve C implementation
picnixz Jul 4, 2024
dad3ef1
improve Python implementation
picnixz Jul 4, 2024
5b8e4a5
update tests
picnixz Jul 4, 2024
a2eef07
remove unused imports
picnixz Jul 4, 2024
9c16c24
address review
picnixz Jul 18, 2024
8f93de3
Merge branch 'main' into fix-ordered-dict
picnixz Jul 20, 2024
8815a17
remove un-necessary comments
picnixz Jul 22, 2024
a714341
update exception message
picnixz Jul 22, 2024
65e6c7e
simplify tests
picnixz Jul 22, 2024
e7363ea
Merge branch 'main' into fix-ordered-dict
picnixz Jul 22, 2024
d59f250
remove unused import
picnixz Jul 22, 2024
b37a048
simplify tests again
picnixz Jul 22, 2024
28c89b2
simplify tests again
picnixz Jul 22, 2024
6c2a684
Update Misc/NEWS.d/next/Library/2024-07-03-14-23-04.gh-issue-119004.L…
picnixz Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify tests again
  • Loading branch information
@picnixz
picnixz committed Jul 22, 2024
commit 28c89b2ed6e6a04e473b273056039b4e1dc06157
8 changes: 4 additions & 4 deletions Lib/test/test_ordered_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,11 +821,11 @@ def side_effect(self):
def test_issue119004_change_size_by_delete_key(self):
class Key(_TriggerSideEffectOnEqual):
def side_effect(self):
del dict1[key1]
del dict1[TODEL]

key1, key2 = Key(), Key()
dict1 = self.OrderedDict(dict.fromkeys((0, key1, 4.2)))
dict2 = self.OrderedDict(dict.fromkeys((0, key2, 4.2)))
TODEL = Key()
dict1 = self.OrderedDict(dict.fromkeys((0, TODEL, 4.2)))
dict2 = self.OrderedDict(dict.fromkeys((0, Key(), 4.2)))
self.check_runtime_error_issue119004(dict1, dict2)
self.assertEqual(Key.count, 2)
self.assertDictEqual(dict1, dict.fromkeys((0, 4.2)))
Expand Down
Loading
0