10000 gh-121245: a regression test for site.register_readline() by skirpichev · Pull Request #121259 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121245: a regression test for site.register_readline() #121259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 3, 2024
Merged

gh-121245: a regression test for site.register_readline() #121259

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8195067
Refactor site.register_readline()
skirpichev Jul 2, 2024
8cbf9e5
+ news entry
skirpichev Jul 2, 2024
9dd6305
+ add cleanup for test file
skirpichev Jul 2, 2024
4c57916
Merge branch 'main' into fix-repl-121245-v2
skirpichev Jul 2, 2024
41d0f3d
Update Lib/site.py (drop history length check)
skirpichev Jul 2, 2024
595e5da
+ test exit_code
skirpichev Jul 2, 2024
e358963
Update Misc/NEWS.d/next/Library/2024-07-02-11-34-06.gh-issue-121245.s…
skirpichev Jul 3, 2024
77a7baa
XXX skip test_not_wiping_history_file() if pyrepl can't be used
skirpichev Jul 3, 2024
8ed572d
Revert "XXX skip test_not_wiping_history_file() if pyrepl can't be used"
skirpichev Jul 3, 2024
753ef78
Merge branch 'master' into fix-repl-121245-v2
skirpichev Jul 3, 2024
f625be8
XXX keep only test
skirpichev Jul 3, 2024
d3dbbfb
+ test with/without basic repl
skirpichev Jul 3, 2024
d4b0f10
Revert news; lets just add a test
skirpichev Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+ test exit_code
  • Loading branch information
@skirpichev
skirpichev committed Jul 2, 2024
commit 595e5da48de80729f8dcf188cbf2e05aad1c005d
1 change: 1 addition & 0 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,7 @@ def test_not_wiping_history_file(self):
env.update({"PYTHON_HISTORY": hfile.name})
commands = "123\nspam\nexit()\n"
output, exit_code = self.run_repl(commands, env=env)
self.assertEqual(exit_code, 0)
self.assertIn("123", output)
self.assertIn("spam", output)
self.assertNotEqual(pathlib.Path(hfile.name).stat().st_size, 0)
Expand Down
Loading
0