gh-121045: Use link test to check whether -fstack-protector-strong works #121258
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't add NEWS entry as this is a minor change. |
|
cc @nohlson |
|
Any update on this ? |
There was a problem hiding this comment.
Instead of hard-coding this to the AIX platform, I would prefer if we could instead rewrite the check to also run the linker, so it would fail on any platform that requires the linker step in order to determine support for this flag. Maybe a configure macro similar to PY_CHECK_CC_WARNING should be added: PY_CHECK_CC_FLAG?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
|
Kindly requesting for reviews |
Sorry, my bandwidth is low these days; I won't be able to revisit these for the next few weeks. Ping me again mid August if I don't get back to you. Thanks for your patience. |
|
Kindly requesting for reviews |
1 similar comment
|
Kindly requesting for reviews |
|
Closing this PR as it is not getting any attention. Also I think the best way to address this issue is to fix the gcc compiler in AIX, so that during compile stage only (-c) it should fail when -fstack-protector-strong is passed. |
This PR is to fix the problem mentioned in the issue #121045.
-fstack-protector-strong is not supported in AIX for gcc compiler and it actually requires a run/link check rather than a compile check to confirm it. And also there is no plan as of now to make it supported in AIX for gcc.