8000 gh-121210: handle nodes with missing attributes/fields in `ast.compare` by picnixz · Pull Request #121211 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121210: handle nodes with missing attributes/fields in ast.compare #121211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2024
Merged

gh-121210: handle nodes with missing attributes/fields in ast.compare #121211

merged 3 commits into from
Jul 2, 2024

Conversation

picnixz
Copy link
Member
@picnixz picnixz commented Jul 1, 2024 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2024
Closed
@picnixz picnixz mentioned this pull request Jul 1, 2024
Merged
JelleZijlstra
JelleZijlstra approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. cc @jeremyhylton who added ast.compare recently.

serhiy-storchaka
serhiy-storchaka approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eclips4 Eclips4 requested a review from jeremyhylton July 1, 2024 18:51
@kumaraditya303 kumaraditya303 merged commit 15232a0 into python:main Jul 2, 2024
36 checks passed
@picnixz picnixz deleted the ast-compare-fix branch July 2, 2024 11:01
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@picnixz @Akasurde
pythongh-121210: handle nodes with missing attributes/fields in `ast.…
cb42763 
…compare` (python#121211)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@picnixz @noahbkim
pythongh-121210: handle nodes with missing attributes/fields in `ast.…
22aea91 
…compare` (python#121211)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@picnixz @estyxx
pythongh-121210: handle nodes with missing attributes/fields in `ast.…
f08e5a4 
…compare` (python#121211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@jeremyhylton jeremyhylton Awaiting requested review from jeremyhylton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@picnixz @JelleZijlstra @serhiy-storchaka @kumaraditya303 @Eclips4
0