8000 [3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi… by csabella · Pull Request #12101 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi… #12101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2019
Merged

[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi… #12101

merged 1 commit into from
Feb 28, 2019

Conversation

csabella
Copy link
Contributor

…mum_version (GH-11894).

(cherry picked from commit ae2ea33)

Co-authored-by: Zhiming Wang i@zhimingwang.org

@zmwangx @csabella
[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi…
08725bf 
…mum_version (pythonGH-11894).

(cherry picked from commit ae2ea33)

Co-authored-by: Zhiming Wang <i@zhimingwang.org>
@bedevere-bot bedevere-bot added skip issue skip news docs Documentation in the Doc dir labels Feb 28, 2019
@miss-islington
Copy link
Contributor

@csabella: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 7dc322f into python:3.7 Feb 28, 2019
@csabella csabella deleted the backport-ae2ea33-3.7 branch February 28, 2019 18:12
vstinner
vstinner reviewed Feb 28, 2019
View reviewed changes
Doc/library/ssl.rst
.. note::
Only available with OpenSSL 1.1.1 and TLS 1.3 enabled. Without TLS 1.3
support, the method raises :exc:`NotImplementedError`.

.. versionadded:: 3.7.1 8000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum wait, why is it version 3.8 in the master branch but 3.7.1 in the 3.7 branch? The versionadded should be the same in 3.7 and master branches, no? cc @csabella @tiran (I only checked verify_client_post_handshake, I didn't check other versionadded markups.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it was when originally added in GH-9460 and GH-9505, so I didn't change it. If it should be 3.7.1 on both, I'll update master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csabella @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @zmwangx
0