8000 gh-120579: Guard `_testcapi` import in `test_free_threading` by sobolevn · Pull Request #120580 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-120579: Guard _testcapi import in test_free_threading #120580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2024
Merged

gh-120579: Guard _testcapi import in test_free_threading #120580

merged 1 commit into from
Jun 16, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jun 16, 2024 •
edited by bedevere-app bot
Loading

After:

» ./python.exe -m test test_free_threading -m test_dict_version -v
== CPython 3.14.0a0 (heads/main-dirty:cf49ef78f89, Jun 16 2024, 10:08:08) [Clang 15.0.0 (clang-1500.3.9.4)]
== macOS-14.4.1-arm64-arm-64bit-Mach-O little-endian
== Python build: debug
== cwd: /Users/sobolev/Desktop/cpython2/build/test_python_worker_59390æ
== CPU count: 12
== encodings: locale=UTF-8 FS=utf-8
== resources: all test resources are disabled, use -u option to unskip tests

Using random seed: 2920195885
0:00:00 load avg: 1.14 Run 1 test sequentially in a single process
0:00:00 load avg: 1.14 [1/1] test_free_threading
test_dict_version (test.test_free_threading.test_dict.TestDict.test_dict_version) ... skipped 'need _testcapi module'

----------------------------------------------------------------------
Ran 1 test in 0.000s

OK (skipped=1)

== Tests result: SUCCESS ==

1 test OK.

Total duration: 45 ms
Total tests: run=1 (filtered) skipped=1
Total test files: run=1/1 (filtered)
Result: SUCCESS

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Jun 16, 2024
@sobolevn sobolevn requested review from DinoV and colesbury June 16, 2024 07:18
@bedevere-app bedevere-app bot mentioned this pull request Jun 16, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jun 16, 2024
@sobolevn sobolevn merged commit 0c0348a into python:main Jun 16, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Sorry, something went wrong.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2024
@sobolevn @miss-islington
pythongh-120579: Guard _testcapi import in test_free_threading (p…
fe1bdf4 
…ythonGH-120580)

(cherry picked from commit 0c0348a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Jun 16, 2024

GH-120583 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 16, 2024
sobolevn added a commit that referenced this pull request Jun 16, 2024
@miss-islington @sobolevn
[3.13] gh-120579: Guard _testcapi import in test_free_threading (G…
f2a4540 
…H-120580) (#120583)

gh-120579: Guard `_testcapi` import in `test_free_threading` (GH-120580)
(cherry picked from commit 0c0348a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@sobolevn @mrahtz
pythongh-120579: Guard _testcapi import in test_free_threading (p…
8677c6a 
…ython#120580)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-120579: Guard _testcapi import in test_free_threading (p…
607ff04 
…ython#120580)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-120579: Guard _testcapi import in test_free_threading (p…
c9e3b75 
…ython#120580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@DinoV DinoV Awaiting requested review from DinoV

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @kumaraditya303 @Eclips4
0