Apply suggestions from code review

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
python · picnixz · Jun 15, 2024 · Jun 15, 2024 · Jun 15, 2024 · Jun 15, 2024
commit c9d4fc260343f754045008cdce16863d9cee26c4
@@ -788,7 +788,7 @@ Instance methods:
        >>> date(2002, 12, 4).isoformat(basic=True)
        '20021204'
 
-   .. versionchanged:: 3.14
+   .. versionchanged:: next
       Added the *basic* parameter.
 
 
@@ -1622,7 +1622,7 @@ Instance methods:
    .. versionchanged:: 3.6
       Added the *timespec* parameter.
 
-   .. versionadded:: 3.14
+   .. versionadded:: next
       Added the *basic* parameter.
 
 
@@ -1985,12 +1985,7 @@ Instance methods:
    - ``HH:MM:SS.ffffff+HH:MM[:SS[.ffffff]]``, if :meth:`utcoffset` does not return ``None``
    - ``HH:MM:SS+HH:MM[:SS[.ffffff]]``, if :attr:`microsecond` is 0 and :meth:`utcoffset` does not return ``None``
 
-   If *basic* is true, this uses the ISO 8601 basic format, one of:
-
-   - ``HHMMSS``
-   - ``HHMMSS.ffffff``
-   - ``HHMMSS+HHMM[SS[.ffffff]]``
-   - ``HHMMSS.ffffff+HHMM[SS[.ffffff]]``
+   If *basic* is true, this uses the ISO 8601 basic format which omits the colons.
 
    The optional argument *timespec* specifies the number of additional
    components of the time to include (the default is ``'auto'``).
@@ -2026,7 +2021,7 @@ Instance methods:
    .. versionchanged:: 3.6
       Added the *timespec* parameter.
 
-   .. versionchanged:: 3.14
+   .. versionchanged:: next
       Added the *basic* parameter.
 
 

diff --git a/Doc/whatsnew/3.14.rst b/Doc/whatsnew/3.14.rst
@@ -435,6 +435,7 @@ datetime
 
   (Contributed by Bénédikt Tran in :gh:`118948`.)
 
+
 os
 --
 

@@ -1570,7 +1570,9 @@ def __hash__(self):
     # Conversion to string
 
     def _tzstr(self, basic):
-        """Return formatted timezone offset (+xx:xx) or an empty string."""
+        """Return formatted timezone offset (+xx:xx) or an empty string.
+        The colon separator is omitted if *basic* is true.
+        """
         off = self.utcoffset()
         sep = '' if basic else ':'
         return _format_offset(off, sep)
@@ -1600,7 +1602,7 @@ def isoformat(self, timespec='auto', basic=False):
         The full format is 'HH:MM:SS.mmmmmm+zz:zz'. By default, the fractional
         part is omitted if self.microsecond == 0.
 
-        If *basic* is true, separators ':' are removed from the output.
+        If *basic* is true, separators ':' are omitted.
 
         The optional argument timespec specifies the number of additional
         terms of the time to include. Valid options are 'auto', 'hours',