8000 gh-120361: Add `nonmember` test with enum flags inside to `test_enum` by sobolevn · Pull Request #120364 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-120361: Add nonmember test with enum flags inside to test_enum #120364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2024
Merged

gh-120361: Add nonmember test with enum flags inside to test_enum #120364

merged 4 commits into from
Jun 14, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jun 11, 2024 •
edited by bedevere-app bot
Loading

I think that this corner case is important enough to be tested.

@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 11, 2024
@sobolevn sobolevn requested a review from ethanfurman as a code owner June 11, 2024 17:56
@bedevere-app bedevere-app bot mentioned this pull request Jun 11, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jun 11, 2024
ethanfurman
ethanfurman requested changes Jun 11, 2024
View reviewed changes
Copy link
Member
@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ambivalent about this being a necessary test, but if we are going to test it let's also test the types (i.e. Example.ALL is an int)

@bedevere-app
Copy link
bedevere-app bot commented Jun 11, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ethanfurman
Copy link
Member

@sobolevn Can you also update Docs/library/enum.rst and change the results of those operators are members of the enumeration to the results of those operations are (aliases of) members of the enumeration ?

@thejcannon Would that addition have helped?

@thejcannon
Copy link
Contributor

I think that I just had a bunch of bad assumptions all built up.

That being said I think your suggestion is good.

thejcannon
thejcannon reviewed Jun 12, 2024
View reviewed changes
@sobolevn sobolevn requested a review from ethanfurman June 13, 2024 13:08
@ethanfurman ethanfurman merged commit 7fadfd8 into python:main Jun 14, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2024
@sobolevn @miss-islington
pythongh-120361: Add nonmember test with enum flags inside to `test…
196c09d 
…_enum` (pythonGH-120364)

* pythongh-120361: Add `nonmember` test with enum flags inside to `test_enum`
(cherry picked from commit 7fadfd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Jun 14, 2024

GH-120511 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2024
@sobolevn @miss-islington
pythongh-120361: Add nonmember test with enum flags inside to `test…
ea55938 
…_enum` (pythonGH-120364)

* pythongh-120361: Add `nonmember` test with enum flags inside to `test_enum`
(cherry picked from commit 7fadfd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Jun 14, 2024

GH-120512 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 14, 2024
sobolevn added a commit that referenced this pull request Jun 14, 2024
@miss-islington @sobolevn
[3.12] gh-120361: Add nonmember test with enum flags inside to `tes…
d2105a1 
…t_enum` (GH-120364) (#120512)

gh-120361: Add `nonmember` test with enum flags inside to `test_enum` (GH-120364)

* gh-120361: Add `nonmember` test with enum flags inside to `test_enum`
(cherry picked from commit 7fadfd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 14, 2024
@miss-islington @sobolevn
[3.13] gh-120361: Add nonmember test with enum flags inside to `tes…
da40fa3 
…t_enum` (GH-120364) (#120511)

gh-120361: Add `nonmember` test with enum flags inside to `test_enum` (GH-120364)

* gh-120361: Add `nonmember` test with enum flags inside to `test_enum`
(cherry picked from commit 7fadfd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@sobolevn @mrahtz
pythongh-120361: Add nonmember test with enum flags inside to `test…
aa1246f 
…_enum` (pythonGH-120364)

* pythongh-120361: Add `nonmember` test with enum flags inside to `test_enum`
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-120361: Add nonmember test with enum flags inside to `test…
0a69022 
…_enum` (pythonGH-120364)

* pythongh-120361: Add `nonmember` test with enum flags inside to `test_enum`
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-120361: Add nonmember test with enum flags inside to `test…
8216c73 
…_enum` (pythonGH-120364)

* pythongh-120361: Add `nonmember` test with enum flags inside to `test_enum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejcannon thejcannon thejcannon approved these changes

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @ethanfurman @thejcannon
0