8000 gh-120111: Don't use cirrus M1 macOS runners on fork by nineteendo · Pull Request #120116 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-120111: Don't use cirrus M1 macOS runners on fork #120116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 6, 2024
Merged

gh-120111: Don't use cirrus M1 macOS runners on fork #120116

merged 10 commits into from
Jun 6, 2024

Conversation

nineteendo
Copy link
Contributor
@nineteendo nineteendo commented Jun 5, 2024 •
edited
Loading

See nineteendo#5 for how this works on a fork.

@bedevere-app bedevere-app bot mentioned this pull request Jun 5, 2024
Closed
@nineteendo nineteendo marked this pull request as draft June 5, 2024 15:25
@nineteendo nineteendo changed the title gh-120111: Exclude cirrus M1 macOS runners on fork gh-120111: Don't use cirrus M1 macOS runners on fork Jun 5, 2024
@nineteendo nineteendo marked this pull request as ready for review June 5, 2024 15:34
@nineteendo
Copy link
Contributor Author

@hugovk, we now use macOS-14 instead of cirrus when running on a fork.

@Eclips4 Eclips4 added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 5, 2024
@nineteendo
Copy link
Contributor Author

I've removed isFork from the name:

-macOS / build and test (macos-13, false)
+macOS / build and test (macos-13)
`

hugovk
hugovk reviewed Jun 5, 2024
View reviewed changes
@nineteendo @hugovk
Apply suggestions from code review
2e37c7e 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@nineteendo
Copy link
Contributor Author

I applied your suggestions.

hugovk
hugovk approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ambv ambv merged commit fd104df into python:main Jun 6, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2024
@nineteendo @hugovk @miss-islington
pythongh-120111: Don't use cirrus M1 macOS runners on fork (pythonGH-…
a87ae75 
…120116)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 6, 2024

GH-120152 is a backport of this pull request to the 3.13 branch.

@miss-islington-app
Copy link 8000

Sorry, @nineteendo and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fd104dfcb838d735ef8128e3539d7a730d403422 3.12

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 6, 2024
ambv pushed a commit to ambv/cpython that referenced this pull request Jun 6, 2024
@nineteendo @hugovk @ambv
[3.12] pythongh-120111: Don't use cirrus M1 macOS runners on fork (py…
fe856e7 
…thonGH-120116)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 6, 2024

GH-120153 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 6, 2024
@nineteendo nineteendo deleted the skip-cirrus-mac-runners branch June 6, 2024 11:54
ambv pushed a commit that referenced this pull request Jun 6, 2024
@miss-islington @nineteendo @hugovk
[3.13] gh-120111: Don't use cirrus M1 macOS runners on fork (GH-120116)…
13e5f45 
… (GH-120152)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv added a commit that referenced this pull request Jun 6, 2024
@ambv @nineteendo @hugovk
[3.12] gh-120111: Don't use cirrus M1 macOS runners on fork (GH-120116)…
94eee78 
… (GH-120153)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@nineteendo @hugovk @noahbkim
pythongh-120111: Don't use cirrus M1 macOS runners on fork (python#12…
780db7f 
…0116)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @hugovk @estyxx
pythongh-120111: Don't use cirrus M1 macOS runners on fork (python#12…
535ca32 
…0116)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk 61F4 hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@ambv ambv

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteendo @hugovk @ambv @Eclips4
0