8000 gh-120065: Increase `collect_in_thread` period to 5 ms. by colesbury · Pull Request #120068 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-120065: Increase collect_in_thread period to 5 ms. #120068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

gh-120065: Increase collect_in_thread period to 5 ms. #120068

merged 2 commits into from
Jun 5, 2024

Conversation

colesbury
Copy link
Contributor
@colesbury colesbury commented Jun 4, 2024 •
edited by bedevere-app bot
Loading

This matches the default GIL switch interval. It greatly speeds up the free-threaded build: previously, it spent nearly all its time in gc.collect().

@colesbury
pythongh-120065: Increase collect_in_thread period to 5 ms.
c7ecf15 
This matches the default GIL switch interval. It greatly speeds up the
free-threaded build: previously, it spent nearly all its time in
`gc.collect()`.
@colesbury colesbury added tests Tests in the Lib/test dir skip news topic-free-threading needs backport to 3.13 bugs and security fixes labels Jun 4, 2024
@colesbury colesbury requested a review from DinoV June 4, 2024 18:56
@bedevere-app bedevere-app bot mentioned this pull request Jun 4, 2024
Closed
@colesbury colesbury merged commit 4bba1c9 into python:main Jun 5, 2024
33 checks passed
@colesbury colesbury deleted the gh-120065-collect-in-thread branch June 5, 2024 13:23
@miss-islington-app
Copy link
miss-islington-app bot commented Jun 5, 2024 8000

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2024
@colesbury @miss-islington
pythongh-120065: Increase collect_in_thread period to 5 ms. (python…
721c3e1 
…GH-120068)

This matches the default GIL switch interval. It greatly speeds up the
free-threaded build: previously, it spent nearly all its time in
`gc.collect()`.
(cherry picked from commit 4bba1c9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 5, 2024

GH-120110 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 5, 2024
colesbury added a commit that referenced this pull request Jun 5, 2024
@miss-islington @colesbury
[3.13] gh-120065: Increase collect_in_thread period to 5 ms. (GH-12…
f561258 
…0068) (#120110)

This matches the default GIL switch interval. It greatly speeds up the
free-threaded build: previously, it spent nearly all its time in
`gc.collect()`.
(cherry picked from commit 4bba1c9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@colesbury @barneygale
pythongh-120065: Increase collect_in_thread period to 5 ms. (python…
ea9287b 
…#120068)

This matches the default GIL switch interval. It greatly speeds up the
free-threaded build: previously, it spent nearly all its time in
`gc.collect()`.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@colesbury @noahbkim
pythongh-120065: Increase collect_in_thread period to 5 ms. (python…
468642c 
…#120068)

This matches the default GIL switch interval. It greatly speeds up the
free-threaded build: previously, it spent nearly all its time in
`gc.collect()`.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-120065: Increase collect_in_thread period to 5 ms. (python…
476710a 
…#120068)

This matches the default GIL switch interval. It greatly speeds up the
free-threaded build: previously, it spent nearly all its time in
`gc.collect()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@DinoV DinoV Awaiting requested review from DinoV

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @Fidget-Spinner
0