8000 gh-119819: Update test to skip if _multiprocessing is unavailable. by vsajip · Pull Request #120067 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-119819: Update test to skip if _multiprocessing is unavailable. #120067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

gh-119819: Update test to skip if _multiprocessing is unavailable. #120067

merged 1 commit into from
Jun 4, 2024

Conversation

vsajip
Copy link
Member
@vsajip vsajip commented Jun 4, 2024 •
edited by bedevere-app bot
Loading

@vsajip vsajip self-assigned this Jun 4, 2024
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jun 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 4, 2024
Closed
@vsajip vsajip merged commit 109e108 into python:main Jun 4, 2024
34 checks passed
@vsajip vsajip deleted the fix-119819 branch June 4, 2024 19:16
@vsajip vsajip added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 4, 2024
@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

8000

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
@vsajip @miss-islington
pythongh-119819: Update test to skip if _multiprocessing is unavailab…
ce97454 
…le. (pythonGH-120067)

(cherry picked from commit 109e108)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-app
Copy link
bedevere-app bot commented Jun 4, 2024

GH-120071 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
@vsajip @miss-islington
pythongh-119819: Update test to skip if _multiprocessing is unavailab…
e13464b 
…le. (pythonGH-120067)

(cherry picked from commit 109e108)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-app
Copy link
bedevere-app bot commented Jun 4, 2024

GH-120072 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2024
vsajip pushed a commit that referenced this pull request Jun 4, 2024
@miss-islington
[3.12] gh-119819: Update test to skip if _multiprocessing is unavaila…
008f9dd 
…ble. (GH-120067) (GH-120071)

(cherry picked from commit 109e108)
vsajip pushed a commit that referenced this pull request Jun 4, 2024
@miss-islington
[3.13] gh-119819: Update test to skip if _multiprocessing is unavaila…
7edc6bd 
…ble. (GH-120067) (GH-120072)

(cherry picked from commit 109e108)
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@vsajip @barneygale
pythongh-119819: Update test to skip if _multiprocessing is unavailab…
a6fb23a 
…le. (pythonGH-120067)
@mhsmith
Copy link
Member
mhsmith commented Jun 13, 2024 •
edited
Loading

@vsajip: It looks like this PR didn't completely fix the issue. The iOS buildbot has been failing for the last few hours because of some iOS version issue – hopefully @freakboy3742 can fix that when he has a chance. But before that, it was failing for the previous 9 days because a logging test was still trying to use multiprocessing.

@freakboy3742
Copy link
Contributor
freakboy3742 commented Jun 13, 2024 •
edited
Loading

@mhsmith That error looks like Xcode has auto-updated itself, but hasn't installed an updated simulator. I've just logged into the machine and completed the install process.

What's weird is that the buildbot interface isn't raising alerts, and (at least for me), the link you've provided (which has previously worked for me), is showing no builds...

Update: It was just very slow. I'm seeing the builds now. But there hasn't been any notifications...

Update 2: There was a notification, but it only notified the first build failure, and I missed that notification.

@freakboy3742 freakboy3742 mentioned this pull request Jun 13, 2024
Merged
@vsajip
Copy link
Member Author
vsajip commented Jun 14, 2024

Do you know why the previous fix (import_helper.import_module('_multiprocessing')) didn't work? Especially as the original error on iOS referred to the inability to import _multiprocessing.

@freakboy3742
Copy link
Contributor

It does work (although requires_subprocess is a slightly more common way to capture the requirement in the rest of the code base). The test failure we're currently seeing is a completely separate test to the one this PR is modifying. That test is currently only guarded on needing threads, but has an implicit dependency on the subprocess capabilities of multiprocessing.

@vsajip
Copy link
Member Author
vsajip commented Jun 14, 2024

OK, but requires_subprocess basically just relies on sys.platform values, right? Conceivably _multiprocessing could be unavailable in other scenarios?

@freakboy3742
Copy link
Contributor

Yes, requires_subprocess is based entirely on sys.platform.

I guess it's possible you might be on a platform where the platform supports subprocesses, but _multiprocessing hasn't been compiled; but given multiprocessing's only real dependency is subprocesses, it's seems highly unlikely. And, in this case, the problematic test doesn't use _multiprocessing at all - it's failing because the pure Python parts of multiprocessing.

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vsajip @noahbkim
pythongh-119819: Update test to skip if _multiprocessing is unavailab…
183e0e2 
…le. (pythonGH-120067)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vsajip @estyxx
pythongh-119819: Update test to skip if _multiprocessing is unavailab…
d6019a9 
…le. (pythonGH-120067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsajip vsajip

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsajip @mhsmith @freakboy3742
0