8000 gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree by jacobtylerwalls · Pull Request #119762 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree #119762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

jacobtylerwalls
Copy link
Contributor
@jacobtylerwalls jacobtylerwalls commented May 30, 2024

Adjust this deprecation warning to refer to returning True regardless of the existence of subelements (rather than raising an exception in 3.14).

I'm not sure whether this should be described as pending for 3.16 or just "future versions".


📚 Documentation preview 📚: https://cpython-previews--119762.org.readthedocs.build/

Copy link
Member
@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gpshead gpshead added the needs backport to 3.13 bugs and security fixes label Jun 7, 2024
@gpshead gpshead merged commit 6b60652 into python:main Jun 7, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @jacobtylerwalls for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2024
… values in ElementTree (pythonGH-119762)

Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
(cherry picked from commit 6b60652)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 7, 2024

GH-120189 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 7, 2024
gpshead pushed a commit to gpshead/cpython that referenced this pull request Jun 7, 2024
… values in ElementTree (pythonGH-119762)

Adjust DeprecationWarning when testing element truth values in
ElementTree, we're planning to go with the more natural True return
rather than a disruptive harder to code around exception raise, and are
deferring the behavior change for a few more releases.
@bedevere-app
Copy link
bedevere-app bot commented Jun 7, 2024

GH-120190 is a backport of this pull request to the 3.12 branch.

gpshead pushed a commit that referenced this pull request Jun 7, 2024
…h values in ElementTree (GH-119762) (GH-120189)

gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree (GH-119762)

Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
(cherry picked from commit 6b60652)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
pygeek pushed a commit to pygeek/cpython that referenced this pull request Jun 7, 2024
… values in ElementTree (pythonGH-119762)

Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
@jacobtylerwalls jacobtylerwalls deleted the adjust-etree-bool-warning branch June 7, 2024 12:33
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
… values in ElementTree (pythonGH-119762)

Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
… values in ElementTree (pythonGH-119762)

Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
Yhg1s pushed a commit that referenced this pull request Aug 6, 2024
…h values in Element tree (GH-119762) (#120190)

gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree (GH-119762)

Adjust DeprecationWarning when testing element truth values in
ElementTree, we're planning to go with the more natural True return
rather than a disruptive harder to code around exception raise, and are
deferring the behavior change for a few more releases.

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0