8000 gh-118908: Limit exposed globals from internal imports and definitions on new REPL startup by eugenetriguba · Pull Request #119547 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-118908: Limit exposed globals from internal imports and definitions on new REPL startup #119547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 11, 2024
Merged

gh-118908: Limit exposed globals from internal imports and definitions on new REPL startup #119547

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
083f0a9
Limit exposed globals in new REPL
eugenetriguba May 25, 2024
bf17576
add blurb
eugenetriguba May 25, 2024
891477b
Merge branch 'main' into gh-118908
eugenetriguba May 25, 2024
2fabf57
tweak test
eugenetriguba May 25, 2024
d5d2321
fix type hint
eugenetriguba May 25, 2024
21a16f8
Add is_using_pyrepl
eugenetriguba May 26, 2024
5c5c496
Merge remote-tracking branch 'upstream/main' into gh-118908
pablogsal Jun 11, 2024
a9c0854
Simplify implementation
pablogsal Jun 11, 2024
d8760e8
Fix mypy
pablogsal Jun 11, 2024
bc49d05
Fix mypy
pablogsal Jun 11, 2024
adb074a
Fix windows
pablogsal Jun 11, 2024
d9a1085
Merge remote-tracking branch 'upstream/main' into gh-118908
pablogsal Jun 11, 2024
cdbc556
Fix generated files
pablogsal Jun 11, 2024
eaa6bc8
Fix generated files
pablogsal Jun 11, 2024
8000
782b231
removed old file
pablogsal Jun 11, 2024
097f21e
Restore old file
pablogsal Jun 11, 2024
549a8d2
update news entry
pablogsal Jun 11, 2024
c95c035
fixup! update news entry
pablogsal Jun 11, 2024
688129b
Update Lib/test/test_pyrepl/test_pyrepl.py
lysnikolaou Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix windows
  • Loading branch information
@pablogsal
pablogsal committed Jun 11, 2024
commit adb074a374f1cb215db716975d0fddf01bb49c59
6 changes: 4 additions & 2 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@
import io
import itertools
import os
import pty
import rlcompleter
import select
import subprocess
import sys
import termios
from unittest import TestCase
from unittest.mock import patch
from test.support import force_not_colorized
Expand Down Expand Up @@ -859,6 +857,10 @@ def test_dumb_terminal_exits_cleanly(self):
self.assertNotIn("Traceback", output)

def run_repl(self, repl_input: str | list[str], env: dict | None = None) -> tuple[str, int]:
try:
import pty
except ImportError:
self.skipTest("pty module not available")
master_fd, slave_fd = pty.openpty()
process = subprocess.Popen(
[sys.executable, "-i", "-u"],
Expand Down
Loading
Loading
0