python · methane · Jun 3, 2024 · May 24, 2024 · May 24, 2024 · May 24, 2024
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
@@ -4016,6 +4016,22 @@ def write(self, data):
         t.write("x"*chunk_size)
         self.assertEqual([b"abcdef", b"ghi", b"x"*chunk_size], buf._write_stack)
 
+    def test_issue119506(self):
+        chunk_size = 8192
+
+        class MockIO(self.MockRawIO):
+            def write(self, data):
+                t.write("efg")
+                return super().write(data)

+        buf = MockIO()
+        t = self.TextIOWrapper(buf)
+        t.write("a" * (chunk_size - 1))
+        t.write("bcd")
+        t.flush()
+
+        self.assertEqual([b"a" * (chunk_size - 1), b"bcdefg"], buf._write_stack)
+
 
 class PyTextIOWrapperTest(TextIOWrapperTest):
     io = pyio

diff --git a/Misc/NEWS.d/next/Library/2024-05-24-14-32-24.gh-issue-119506.-nMNqq.rst b/Misc/NEWS.d/next/Library/2024-05-24-14-32-24.gh-issue-119506.-nMNqq.rst
@@ -0,0 +1 @@
+Fix bug in :meth:`!io.TextIOWrapper.write` method, which causes wrapper's internal buffer to be rewritten during flushing of large data.
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
@@ -1719,21 +1719,31 @@ _io_TextIOWrapper_write_impl(textio *self, PyObject *text)
         bytes_len = PyBytes_GET_SIZE(b);
     }
 
-    if (self->pending_bytes == NULL) {
-        self->pending_bytes_count = 0;
-        self->pending_bytes = b;
-    }
-    else if (self->pending_bytes_count + bytes_len > self->chunk_size) {
+    PyObject *pending = self->pending_bytes;
+
+    if (self->pending_bytes_count + bytes_len > self->chunk_size) {
         // Prevent to concatenate more than chunk_size data.
         if (_textiowrapper_writeflush(self) < 0) {
             Py_DECREF(b);
             return NULL;
         }
+        if (self->pending_bytes) {
+            // gh-119506: call to _textiowrapper_writeflush()
+            // can write new data to pending_bytes
+            pending = self->pending_bytes;
+            self->pending_bytes = b;
+            b = pending;
+        }
+    }
+
+    if (self->pending_bytes == NULL) {
+        self->pending_bytes_count = 0;
         self->pending_bytes = b;
     }
     else if (!PyList_CheckExact(self->pending_bytes)) {
         PyObject *list = PyList_New(2);
         if (list == NULL) {
+            self->pending_bytes = pending;
             Py_DECREF(b);
             return NULL;
         }
@@ -1743,6 +1753,7 @@ _io_TextIOWrapper_write_impl(textio *self, PyObject *text)
     }
     else {
         if (PyList_Append(self->pending_bytes, b) < 0) {
+            self->pending_bytes = pending;
             Py_DECREF(b);
             return NULL;
         }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug in :meth:`!io.TextIOWrapper.write` method, which causes wrapper's internal buffer to be rewritten during flushing of large data.