gh-111201: Speed up paste mode in the REPL #119341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #119318 landing first |
|
I think that this has broken paste. Pasting code shows the last character of the pasted line only. The whole buffer is shown after hitting backspace. If arrows are used between the paste and the backspace, the buffer gets completely messed up. cc @ambv @pablogsal |
|
Hummm, we live tested this several times. I wonder if there is some weird interaction with other PRs we landed |
|
We should revert meanwhile I think |
|
@lysnikolaou @ambv WDYT? |
|
+1 for reverting, otherwise it might be hard to do manual testing of PRs at the sprints. |
|
#119432 fixes this. |
lysnikolaou
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
lysnikolaou
added a commit
that referenced
this pull request
May 23, 2024
… (#119439) (cherry picked from commit e6572e8) Also includes: * gh-111201: Use calc_complete_screen after bracketed paste in PyREPL (GH-119432) (cherry picked from commit 14b063c) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.