8000 gh-119247: Add macros to use PySequence_Fast safely in free-threaded build by MojoVampire · Pull Request #119315 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-119247: Add macros to use PySequence_Fast safely in free-threaded build #119315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 22, 2024
Merged

gh-119247: Add macros to use PySequence_Fast safely in free-threaded build #119315

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b22f6e2
Initial work on critical sections for fast sequences while developing…
MojoVampire May 21, 2024
2b4fe19
Test for efficacy of fast sequence locking macro on str.join, both te…
MojoVampire May 21, 2024
536defc
Blurb for change
MojoVampire May 21, 2024
0475c8e
Update Include/internal/pycore_critical_section.h
MojoVampire May 21, 2024
1f3cec0
Tweak comments per review
MojoVampire May 21, 2024
707852d
Use braced if per review
MojoVampire May 21, 2024
66f0e6c
Per review, refactor extend test to extend multiple times, and reduce…
MojoVampire May 21, 2024
515ee56
Remove listobject.h include per review (all users of pycore_critical_…
MojoVampire May 21, 2024
254a5a5
Reduce readers in test_racing_join_replace to 10, use Event to synchr…
MojoVampire May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak comments per review 
Co-authored-by: Sam Gross <colesbury@gmail.com>
  • Loading branch information
@MojoVampire @colesbury
MojoVampire and colesbury committed May 22, 2024
commit 1f3cec034c671148f30bc6a29e4b9430175a4c7e
10 changes: 5 additions & 5 deletions Include/internal/pycore_critical_section.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ extern "C" {
_PyCriticalSection2_End(&_cs2); \
}

// Specialized version of critical section locking called to safely use
// PySequence_Fast APIs under nogil
// For performance, the argument *to* PySequence_Fast is provided to the
// macro, not the *result* of PySequence_Fast (which would require an extra
// test to determine if the lock must be held)
// Specialized version of critical section locking to safely use
// PySequence_Fast APIs without the GIL. For performance, the argument *to*
// PySequence_Fast() is provided to the macro, not the *result* of
// PySequence_Fast(), which would require an extra test to determine if the
// lock must be acquired.
# define Py_BEGIN_CRITICAL_SECTION_SEQUENCE_FAST(original) \
{ \
PyObject *_orig_seq = _PyObject_CAST(original); \
Expand Down
0