10000 gh-118508: Clarify which characters are matched by `\s` by nineteendo · Pull Request #119155 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-118508: Clarify which characters are matched by \s #119155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

gh-118508: Clarify which characters are matched by \s #119155

merged 1 commit into from
Sep 2, 2024

Conversation

nineteendo
Copy link
Contributor
@nineteendo nineteendo commented May 18, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels May 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 18, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review May 18, 2024 20:22
blaisep
blaisep approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor
@blaisep blaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additional clarification, thank you

@nineteendo
Copy link
Contributor Author

@kumaraditya303, you merged a recent regex clarification. Would you like to merge this one as well?

@nedbat nedbat merged commit 22fdb8c into python:main Sep 2, 2024
39 checks passed
@nineteendo nineteendo deleted the clarify-re-syntax branch September 2, 2024 11:53
@nineteendo
Copy link
Contributor Author

Thanks.

@nineteendo
Copy link
Contributor Author

Do we close the issue or do we backport the change?

@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 4, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @nedbat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @nedbat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2024
@nineteendo @miss-islington
pythongh-118508: Clarify which characters are matched by \s (python…
3744a95 
…GH-119155)

Clarify re syntax
(cherry picked from commit 22fdb8c)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Sep 4, 2024

GH-123670 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2024
@nineteendo @miss-islington
pythongh-118508: Clarify which characters are matched by \s (python…
da6f376 
…GH-119155)

Clarify re syntax
(cherry picked from commit 22fdb8c)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@encukou
Copy link
Member
encukou commented Sep 4, 2024

Docs fixes are generally backported.

@bedevere-app
Copy link
bedevere-app bot commented Sep 4, 2024

GH-123671 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 4, 2024
hauntsaninja pushed a commit that referenced this pull request Sep 4, 2024
@miss-islington @nineteendo
[3.13] gh-118508: Clarify which characters are matched by \s (GH-11…
3b37658 
…9155) (#123670)

gh-118508: Clarify which characters are matched by `\s` (GH-119155)

Clarify re syntax
(cherry picked from commit 22fdb8c)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
hauntsaninja pushed a commit that referenced this pull request Sep 4, 2024
@miss-islington @nineteendo
[3.12] gh-118508: Clarify which characters are matched by \s (GH-11…
a0c9f51 
…9155) (#123671)

gh-118508: Clarify which characters are matched by `\s` (GH-119155)

Clarify re syntax
(cherry picked from commit 22fdb8c)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaisep blaisep blaisep approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteendo @encukou @blaisep @nedbat
0