8000 [3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) by zooba · Pull Request #118742 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2024
Merged

[3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86da8de
gh-118486: Support mkdir(mode=0o700) on Windows
zooba May 1, 2024
3f5e5f5
Fix CVE in docs
zooba May 7, 2024
f7dd957
Apply suggestions from code review
zooba May 7, 2024
0069b38
Use language-invariant ACL
zooba May 9, 2024
c4b3f7a
gh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (GH-1…
zooba May 15, 2024
18afc1f
Merge branch '3.8' into gh-118486-3.8
ambv May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@zooba
zooba authored May 7, 2024
commit f7dd957511389a8845782f079997aa45bf77c09d
6 changes: 3 additions & 3 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,9 +1382,9 @@ def test_exist_ok_existing_regular_file(self):

@unittest.skipUnless(os.name == 'nt', "requires Windows")
def test_win32_mkdir_700(self):
base = os_helper.TESTFN
path1 = os.path.join(os_helper.TESTFN, 'dir1')
path2 = os.path.join(os_helper.TESTFN, 'dir2')
base = support.TESTFN
path1 = os.path.join(support.TESTFN, 'dir1')
path2 = os.path.join(support.TESTFN, 'dir2')
# mode=0o700 is special-cased to override ACLs on Windows
# There's no way to know exactly how the ACLs will look, so we'll
# check that they are different from a regularly created directory.
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ def test_mode_win32(self):
acl = None
# First line of result includes our directory
if line.startswith(dir):
acl = line.removeprefix(dir).strip()
acl = line[len(dir):].strip()
elif line and line[:1].isspace():
acl = line.strip()
if acl:
Expand Down
0