8000 gh-109975: Update 'What's New in Python 3.13' for beta by hugovk · Pull Request #118694 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-109975: Update 'What's New in Python 3.13' for beta 8000 #118694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

gh-109975: Update 'What's New in Python 3.13' for beta #118694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0757590
Update 'What's New in Python 3.13' for beta
hugovk May 1, 2024
9bf5515
Fix some Sphinx warnings in changelog
hugovk May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ Other Language Changes
New Modules
===========

* None yet.
* None.


Improved Modules
Expand Down Expand Up @@ -1647,7 +1647,7 @@ PEP 594: dead batteries
* :mod:`!pipes`: use the :mod:`subprocess` module instead.
(Contributed by Victor Stinner in :gh:`104773`.)

* :mod:`!sndhdr`: use the projects :pypi:`filetype_,
* :mod:`!sndhdr`: use the projects :pypi:`filetype`,
:pypi:`puremagic`, or :pypi:`python-magic` instead.
(Contributed by Victor Stinner in :gh:`104773`.)

Expand Down Expand Up @@ -1791,11 +1791,6 @@ webbrowser
attribute instead.
(Contributed by Nikita Sobolev in :gh:`105546`.)

Others
------

* None yet

CPython bytecode changes
========================

Expand Down
5 changes: 3 additions & 2 deletions Misc/NEWS.d/next/C API/2024-04-08-09-44-29.gh-issue-117534.54ZE_n.rst
View file
Open in desktop
8000
Original file line numberDiff line number Diff line change
@@ -1,2 +1,3 @@
Improve validation logic in the C implementation of :meth:`datetime.fromisoformat`
to better handle invalid years. Patch by Vlad Efanov.
Improve validation logic in the C implementation of
:meth:`datetime.datetime.fromisoformat` to better handle invalid years.
Patch by Vlad Efanov.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why these weren't caught on the PR adding them? Is there some configuration change we can make so that NEWS entries get linted properly by Sphinx?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lint them with Sphinx Lint, but that doesn't catch everything, especially not bad references.

We only check for warnings from a Sphinx build in files under Doc/:

cpython/Doc/tools/check-warnings.py

Lines 212 to 216 in c4f9823

all_rst = {
str(rst)
for rst in Path("Doc/").rglob("*.rst")
if rst.parts[1] not in EXCLUDE_SUBDIRS
}

We ignore those that are in .nitignore because they've not been "cleaned" yet, because we don't want to hassle people over warnings which they didn't introduce.

Similarly, we ignore the news files, because during the Sphinx build, they get compiled into a giant 45k line build/NEWS which has 700+ warnings (and growing, because we don't check them).

And so we don't want to warn for every single PR that adds a small NEWS blurb about those 700 warnings that they didn't introduce.

New entries are added to the top of the compiled NEWS file. One option would be to add a check to ensure the top X lines remain clean. Most NEWS entries are under 10 lines long, and the biggest right now is 18 lines, so checking something like the top 200 or so would prevent new warnings being introduced.

I started work on this in February, see hugovk#61. I'll pick this up again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see PR #119221.

2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2018-02-13-10-02-54.bpo-32839.McbVz3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Add the :meth:`after_info` method for Tkinter widgets.
Add the :meth:`!after_info` method for Tkinter widgets.
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2024-04-17-21-28-24.gh-issue-116931._AS09h.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Add parameter *fileobj* check for :func:`tarfile.addfile()`
Add parameter *fileobj* check for :func:`tarfile.TarFile.addfile`
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2024-04-24-12-20-48.gh-issue-118013.TKn_kZ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ to that instance's class to persist in an internal cache in the
class was dynamically created, the class held strong references to other
objects which took up a significant amount of memory, and the cache
contained the sole strong reference to the class. The fix for the regression
leads to a slowdown in :func:`getattr_static`, but the function should still
leads to a slowdown in :func:`!getattr_static`, but the function should still
be significantly faster than it was in Python 3.11. Patch by Alex Waygood.
5 changes: 3 additions & 2 deletions Misc/NEWS.d/next/Library/2024-04-24-12-29-33.gh-issue-118221.2k_bac.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
Fix a bug where :func:`sqlite3.iterdump` could fail if a custom :attr:`row
factory <sqlite3.Connection.row_factory>` was used. Patch by Erlend Aasland.
Fix a bug where :meth:`sqlite3.Connection.iterdump` could fail if a custom
:attr:`row factory <sqlite3.Connection.row_factory>` was used. Patch by Erlend
Aasland.
Loading
0