gh-118201 - Disable the flaky POSIX test_confstr test on iOS #118452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned-deily
approved these changes
Apr 30, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 1 in 10 builds appear to be failing on iOS due to the
test.test_posix.PosixTester.test_confstrtest. The next buildbot run almost always passes, with no other changes.For want of a real fix, this PR skips that test on iOS to avoid misleading test failures from the buildbot.
I agree this isn't a very satisfying "fix", but I've been unable to reproduce the issue locally. However, in defence of the fix: the feature that is failing doesn't have much utility on iOS. It's no help knowing where the POSIX standard utilities are located (which is what is returned by the value
CS_PATH), because you can't invoke them anyway. The other common values passed toconfstr()appear to be GNU C dependent (FreeBSD only documentsCS_PATH).There's also precedent for this approach - there's a couple of other tests in the suite that are skipped as being "flaky" under specific build conditions.
If this is merged, we can keep the underlying ticket open on the off chance that someone is affected by the issue, or is able to find a way to reproduce it.