gh-112069: Add _PySet_NextEntryRef to be threa 8000 d-safe. #117990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
OKay, it's too slow. |
colesbury
reviewed
Apr 17, 2024
There was a problem hiding this comment.
I'm not sure what the right approach here is, but as written _PySet_NextEntry still returns a borrowed reference, so the cases that were not thread-safe are probably still not thread-safe.
I don't think it makes sense to try to make individual calls to _PySet_NextEntry thread-safe. The whole loop of while(_PySet_NextEntry(...)) is generally what needs to be thread-safe. For example, the comment in set_next says:
Lines 477 to 478 in fccedbd
I think we should add locking in the use sites of _PySet_NextEntry as necessary. Most look like they're already okay to me: either they already do locking (listobject.c and dictobject.c) or operate on private or immutable data (pylifecycle.c, codeobject.c).
The two cases that concern me and may need locking are:
_pickle.cmarshal.c
|
buildbot/AMD64 RHEL7 Refleaks PR: Unrelated |
colesbury
reviewed
Apr 17, 2024
There was a problem hiding this comment.
- We should not change the reference count behavior of
_PySet_NextEntryas it's exposed publicly and used outside of CPython (like in Cython). If needed, add a new function_PySet_NextEntryRef. - I don't think
_PyFrozenSet_NextEntryis needed._PySet_NextEntry(or_PySet_NextEntryRef) looks sufficient.
53f949a to
99fb7e6
Compare
Need to check. |
|
test_compile: #118023 So leaks are not related to this PR. |
colesbury
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setthread-safe in--disable-gilbuilds #112069