8000 gh-117889: Fix PGO test in test_peg_generator by vstinner · Pull Request #117893 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117889: Fix PGO test in test_peg_generator #117893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

gh-117889: Fix PGO test in test_peg_generator #117893

merged 2 commits into from
Apr 15, 2024

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Apr 15, 2024 •
edited by bedevere-app bot
Loading

Reuse support.check_cflags_pgo() in test_peg_generator to check if PGO build is used or not.

8000
@vstinner vstinner added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Apr 15, 2024
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Apr 15, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 15, 2024
Closed
@vstinner vstinner removed the needs backport to 3.11 only security fixes label Apr 15, 2024
vstinner added 2 commits April 15, 2024 15:29
@vstinner
pythongh-117889: Fix PGO test in test_peg_generator
b0afdac 
Reuse support.check_cflags_pgo() in test_peg_generator to check if
PGO build is used or not.
@vstinner
test.pythoninfo logs PGO_PROF_USE_FLAG
b95aa47
@erlend-aasland
Copy link
Contributor

Thank you Victor!

@vstinner vstinner enabled auto-merge (squash) April 15, 2024 13:45
@erlend-aasland erlend-aasland mentioned this pull request Apr 15, 2024
Merged
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@vstinner vstinner merged commit 64cd6fc into python:main Apr 15, 2024
@vstinner vstinner deleted the test_peg_gen branch April 15, 2024 13:59
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 15, 2024
@vstinner @miss-islington
pythongh-117889: Fix PGO test in test_peg_generator (pythonGH-117893)
a6a1573 
Reuse support.check_cflags_pgo() in test_peg_generator to check for
PGO build.

Log PGO_PROF_USE_FLAG in test.pythoninfo.
(cherry picked from commit 64cd6fc)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Apr 15, 2024

GH-117895 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 15, 2024
erlend-aasland pushed a commit that referenced this pull request Apr 15, 2024
@miss-islington @vstinner
[3.12] gh-117889: Fix PGO test in test_peg_generator (GH-117893) (#11…
6a4c06b 
…7895)

Reuse support.check_cflags_pgo() in test_peg_generator to check for
PGO build.

Log PGO_PROF_USE_FLAG in test.pythoninfo.
(cherry picked from commit 64cd6fc)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Copy link
Member Author

Merged, thanks for the review @erlend-aasland.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-117889: Fix PGO test in test_peg_generator (python#117893)
e015fc7 
Reuse support.check_cflags_pgo() in test_peg_generator to check for
PGO build.

Log PGO_PROF_USE_FLAG in test.pythoninfo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @erlend-aasland @bedevere-bot
0