8000 gh-117431: Improve performance of startswith and endswith by eendebakpt · Pull Request #117782 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117431: Improve performance of startswith and endswith #117782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gh-117431: Improve performance of startswith and endswith #117782

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
035b3e2
Improve performance of startswith by eliminating double work in tailm…
eendebakpt Apr 11, 2024
4f4b084
code style
eendebakpt Apr 11, 2024
9f201b1
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 11, 2024
8792d0b
lint
eendebakpt Apr 11, 2024
0be010f
Merge branch 'main' into tailmatch_v2
eendebakpt May 11, 2024
2a2cfb3
Update Objects/unicodeobject.c
eendebakpt May 20, 2024
9f8e4b8
update comment
eendebakpt May 20, 2024
642d2bc
Merge branch 'tailmatch_v2' of github.com:eendebakpt/cpython into tai…
eendebakpt May 20, 2024
1693405
Merge branch 'main' into tailmatch_v2
eendebakpt May 20, 2024
8a7b9fe
update news entry
eendebakpt May 21, 2024
2fff994
Merge branch 'main' into tailmatch_v2
eendebakpt May 21, 2024
ed8b9d3
Update Misc/NEWS.d/next/Core and Builtins/2024-04-11-21-17-23.gh-issu…
eendebakpt May 21, 2024
378b586
Merge branch 'main' into tailmatch_v2
eendebakpt Jul 28, 2024
6bf1d0c
Merge branch 'main' into tailmatch_v2
eendebakpt Sep 29, 2024
8779d23
Merge branch 'main' into tailmatch_v2
eendebakpt Feb 10, 2025
abe35e8
reduce churn
eendebakpt Feb 10, 2025
febac50
Merge branch 'main' into tailmatch_v2
asvetlov Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code style
  • Loading branch information
@eendebakpt
eendebakpt committed Apr 11, 2024
commit 4f4b084eadd50e65f165ad011777e5a7991ff240
9 changes: 5 additions & 4 deletions Objects/unicodeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9272,12 +9272,13 @@ tailmatch(PyObject *self,
else
offset = start;

int last_character_matches = PyUnicode_READ(kind_self, data_self, offset + end_sub) ==
PyUnicode_READ(kind_sub, data_sub, end_sub);
int match_last = PyUnicode_READ(kind_self, data_self, offset + end_sub) ==
PyUnicode_READ(kind_sub, data_sub, end_sub);

if (last_character_matches) {
if (end_sub==0)
if (match_last) {
if (end_sub==0) {
return 1;
}
/* If both are of the same kind, memcmp is sufficient */
if (kind_self == kind_sub) {
return ! memcmp((char *)data_self + (offset * kind_sub),
Expand Down
0