8000 gh-117692: Fix `AttributeError` in `DocTestFinder` on wrapped `builtin_or_method` by sobolevn · Pull Request #117699 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method #117699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom< 8000 /a>
Merged
merged 2 commits into from
Apr 10, 2024
Merged

gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method #117699

merged 2 commits into from
Apr 10, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Apr 9, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from AlexWaygood April 9, 2024 20:30
@bedevere-app bedevere-app bot mentioned this pull request Apr 9, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Apr 10, 2024
@AlexWaygood
Copy link
Member

@pablogsal -- the PR that caused the regression here was unfortunately backported to 3.11. But I assume we can't backport this fix that far, given that 3.11 is now in security-only mode?

@sobolevn @AlexWaygood
Update Lib/doctest.py
7425043 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood merged commit 4bb7d12 into python:main Apr 10, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2024
@sobolevn @AlexWaygood @miss-islington
pythongh-117692: Fix AttributeError in DocTestFinder on wrapped `…
7aea2ee 
…builtin_or_method` (pythonGH-117699)

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Apr 10, 2024

GH-117708 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 10, 2024
AlexWaygood added a commit that referenced this pull request Apr 10, 2024
@miss-islington @sobolevn @AlexWaygood
[3.12] gh-117692: Fix AttributeError in DocTestFinder on wrapped …
653ed76 
…`builtin_or_method` (GH-117699) (#117708)

* gh-117692: Fix `AttributeError` in `DocTestFinder` on wrapped `builtin_or_method` (GH-117699)
(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @AlexWaygood @diegorusso
pythongh-117692: Fix AttributeError in DocTestFinder on wrapped `…
e34cb13 
…builtin_or_method` (python#117699)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @AlexWaygood
0