8000 Remove Python 3.5 hardcoded version in the tutorial appendix by Privat33r-dev · Pull Request #117612 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Remove Python 3.5 hardcoded version in the tutorial appendix #117612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2024
Merged

Remove Python 3.5 hardcoded version in the tutorial appendix #117612

merged 3 commits into from
May 7, 2024

Conversation

Privat33r-dev
Copy link
Contributor
@Privat33r-dev Privat33r-dev commented Apr 7, 2024 •
edited by github-actions bot
Loading

The python<your_python_version> one still makes me think of a better solution: I've tried |python_x_dot_y_literal|, |version| with detaching output in another text, but python|version| is not being substituted and the first one includes double backticks. I don't want to edit conf.py just for this minor change, so I left it as is for now. I would appreciate any feedback on this.

📚 Documentation preview 📚: https://cpython-previews--117612.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 7, 2024
@Privat33r-dev
Copy link
Contributor Author

Does the PR need an issue, @AlexWaygood ? It's kind of small, almost "typo fix".

@AlexWaygood
Copy link
Member

Does the PR need an issue, @AlexWaygood ? It's kind of small, almost "typo fix".

nah, we can skip an issue for a 2-line docs fix :-)

@Privat33r-dev
Copy link
Contributor Author

Hopefully this one-liner will be reviewed one day :)

encukou
encukou reviewed May 6, 2024
View reviewed changes
@Privat33r-dev @encukou
Change example
4f61697 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou merged commit a855f82 into python:main May 7, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @Privat33r-dev for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2024
@Privat33r-dev @miss-islington
Remove Python 3.5 hardcoded version in the tutorial appendix (pythonG…
f0d8038 
…H-117612)

(cherry picked from commit a855f82)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
@bedevere-app
Copy link
bedevere-app bot commented May 7, 2024

GH-118707 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label May 7, 2024
@Privat33r-dev Privat33r-dev deleted the patch-2 branch May 7, 2024 13:30
@encukou
Copy link
Member
encukou commented May 7, 2024

Thank you for the fix!

encukou pushed a commit that referenced this pull request May 7, 2024
@miss-islington @Privat33r-dev
[3.12] Remove Python 3.5 hardcoded version in the tutorial appendix (G…
efbc8c7 
…H-117612) (GH-118707)

Remove Python 3.5 hardcoded version in the tutorial appendix (GH-117612)
(cherry picked from commit a855f82)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@Privat33r-dev @SonicField
Remove Python 3.5 hardcoded version in the tutorial appendix (pythonG…
75c78a0 
…H-117612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Privat33r-dev @AlexWaygood @encukou
0