Fix a typo i 8000 n dictobject.c documentation #117515
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Seeing as the CLA bot points me back to the same form, could I get some clarification on
|
Copying @ambv, our lead developer in residence, for additional guidance. Lukasz, Noah is a wonderful dev and part of the Hudson River Trading team. Could you please help to answer Noah's questions. @noahbkim Do you see the following when you click on the cla button to sign? If so, you should be able to authorize the CLA bot via your GitHub account. Or is that what is redirecting you to the form on the PSF website (https://www.python.org/psf/contrib/contrib-form/)? Thanks Lukasz in advance for your help and Noah for your patience. |
I do, but the button seems to correspond to the individual CLA, not the organization one. I imagine the process is slightly different for when I contribute with my HRT hat on. |
|
I had sent this email to contributors@python.org a little over a year ago (and then bumped it to Sarah Swienckowski-Eckhart and Phyllis A. Dobbs a few times), but never actually got a response. If we can get some clarity on how the CLA process works for organizations (where people will need to be contributing under the HRT CLA when doing that as part of job duties, separate from individual duties), that would be a great help and let us move forward.
I do see that the Docusign version no longer mentions bpo (though the PDF version still does). But there's still the question of how to manage associating GitHub accounts of HRT employees with this CLA. Should we have an authorized signatory Docusign the form with the account information (email address, I guess) for @noahbkim? And then repeat for each employee of HRT who needs to contribute under this CLA? Thanks for helping us look into this! |
|
Bumping this thread! |
|
As for the corporate CLA, we need a corporate CLA form only once per organization. And we only need it in some situations. You, or another appropriate representative, need to submit this form on behalf of your employer (with their consent) whenever your work's copyright is in any way tied to your employment. You need to determine whether that's true for your jurisdiction and work situation. The email on the corporate CLA form should ideally come from a domain belonging to the organization in question, and the personal identification of "Contributor" on the corporate CLA form should be the legal name of the company's representative and their signature, not a GitHub username. The form is now updated and no longer contains the outdated Now, after you do this, your first PR will still ask you to sign a personal CLA. You see, it's not enough for the PSF to accept a blanket form for "each and any" contributor falling under an organization as organization membership might not be well represented on GitHub at the time of contributing a PR, and so on. In any case, you will be signing a personal CLA through GitHub no matter what. But we can't give you legal advice as to how you personally should distinguish personal from corporate contributions. For instance, in California, personal contribution performed on your own time using your personal hardware can still be challenged as work-related if it is related to your day job duties. One popular choice to separate work from personal activity is to have your work email address listed on your GitHub account and to use that email for all git commits done as part of your work. This becomes tricky when some actions are performed through the GitHub UI which creates commits for you. So some people go as far as to have separate work accounts for GitHub. |
|
Alright! We've signed the organization CLA on docusign as HRT Research LLC and I've just now signed the individual CLA. Is there anything else I need to do before I submit this other than amend the commit to use my HRT email address? Thanks again for all the help 😄 |
|
That's it, Noah. Thank you! |
Fix a typo in dictobject.c documentation
This change fixes grammar in a comment in
dictobject.c. Its true purpose is to kick off the CLA process so that I & other developers can contribute to CPython on behalf of Hudson River Trading.Tagging @willingc as requested!