8000 gh-102555 Increase HTML standard compliance for closing comment tags by Privat33r-dev · Pull Request #117406 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-102555 Increase HTML standard compliance for closing comment tags #117406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

gh-102555 Increase HTML standard compliance for closing comment tags #117406

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c91c5ce
Increase HTML standard compliance for closing comment tags
Privat33r-dev Mar 31, 2024
4536d8b
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 31, 2024
9147ff6
Add more edge cases and tests
Privat33r-dev Apr 6, 2024
eafb2d2
Add invalid HTML comment closing tags test cases
Privat33r-dev Apr 6, 2024
9e687bf
Add html closing comment tags test cases
Privat33r-dev Apr 6, 2024
caba267
Add EOF abrupted comment tag case handling and tests
Privat33r-dev Apr 6, 2024
23d35c6
Merge branch 'main' into patch-1
Privat33r-dev Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add invalid HTML comment closing tags test cases
  • Loading branch information
@Privat33r-dev
Privat33r-dev committed Apr 6, 2024
commit eafb2d2a84b9b244a6c8a744a5eb6b6f43fddd94
11 changes: 9 additions & 2 deletions Lib/test/test_htmlparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,10 @@ def test_comments(self):
'<!--->'
'<!-->'
'<!--<!--->'
'<!--incorrectly-closed-comment--!>')
'<!--And I am so-called incorrectly-closed-comment--!>'
'<!--I have invalid attempt to close (space) -- >-->'
'<!--Me too (invalid character) --x>-->'
'<!--Me too (invalid characters) --cheese>-->')
expected = [('comment', " I'm a valid comment "),
('comment', 'me too!'),
('comment', '--'),
Expand All @@ -339,7 +342,11 @@ def test_comments(self):
('comment', ''),
('comment', ''),
('comment', '<!-'),
('comment', 'incorrectly-closed-comment')]
('comment', 'And I am so-called incorrectly-closed-comment'),
('comment', 'I have invalid attempt to close (space) -- >'),
('comment', 'Me too (invalid character) --x>'),
('comment', 'Me too (invalid characters) --cheese>')
]
self._run_check(html, expected)

def test_condcoms(self):
Expand Down
0