8000 gh-117281: Change weakref repr() to fully qualified name by vstinner · Pull Request #117285 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-117281: Change weakref repr() to fully qualified name #117285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Mar 27, 2024

Use the fully qualified type name in repr() of weakref.ref and weakref.proxy types.

Fix a crash in proxy_repr() when the reference is dead.

Add also test_ref_repr() and test_proxy_repr().

Use the fully qualified type name in repr() of weakref.ref and
weakref.proxy types.

Fix a crash in proxy_repr() when the reference is dead.

Add also test_ref_repr() and test_proxy_repr().
@vstinner
Copy link
Member Author

cc @erlend-aasland @Eclips4

Copy link
Member
@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vstinner
Copy link
Member Author

cc @serhiy-storchaka

@vstinner vstinner merged commit 8ef9892 into python:main Apr 3, 2024
@vstinner vstinner deleted the proxy_repr branch April 3, 2024 10:18
@vstinner
Copy link
Member Author
vstinner commented Apr 3, 2024

Merged, thanks for the review @Eclips4.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…n#117285)

Use the fully qualified type name in repr() of weakref.ref and
weakref.proxy types.

Fix a crash in proxy_repr() when the reference is dead.

Add also test_ref_repr() and test_proxy_repr().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0