-
-
Notifications
You must be signed in to change notification settings - Fork 32k
8000
gh-116968: Reimplement Tier 2 counters #117144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
e7e819b
Baby steps: reimplement thresholds using adaptive counter abstractions
gvanrossum 8c74dfa
Make temperature an adaptive counter like the rest
gvanrossum 79036ff
Fix tests
gvanrossum 54c1f8e
Remove dead adaptive_counter_jump_init()
gvanrossum 015bb00
Fix no-GIL build failure in _COLD_EXIT
gvanrossum 1730295
Use the right named constant in initial temperature
gvanrossum 95f93b7
Add pycore_backoff.h, and include it, but don't use it yet
gvanrossum 7df0f10
Reimplement adaptive counters in terms of backoff_counter
gvanrossum 925cae7
Redefine T2 temperature as a backoff counter
gvanrossum f0c7fb0
Don't increment branch cache (bitmask) in INSTRUMENTED_INSTRUCTION
gvanrossum 8f79a60
Don't increment branch cache (bitmask) in INSTRUMENTED_LINE
gvanrossum 149e9c4
Don't update unreachable counters
gvanrossum 1d76112
Simplify dynamic counter initialization for JUMP_BACKWARD
gvanrossum a5ffe02
Revert "Don't increment branch cache (bitmask) in INSTRUMENTED_LINE"
gvanrossum ce7726c
Different approach to avoid incrementing bitmask in INSTRUMENTED_LINE
gvanrossum e2c39f2
Different approach to avoid incrementing bitmask in INSTRUMENTED_INST…
gvanrossum 8d22790
Fix dynamic counter initialization for JUMP_BACKWARD
gvanrossum cd8264e
Get rid of (unused) resume_threshold
gvanrossum d72c2ef
Hopeful fix for non-clang builds
gvanrossum f6bf194
In no-GIL mode, make INCREMENT_ADAPTIVE_COUNTER() a no-op
gvanrossum b991843
Revert "In no-GIL mode, make INCREMENT_ADAPTIVE_COUNTER() a no-op"
gvanrossum 9b9f26a
Fix comment and fix size of optimizer_backedge_threshold
gvanrossum 354cd81
_COLD_EXIT is not conditional on ENABLE_SPECIALIZATION
gvanrossum c1de44f
Rewrite _COLD_EXIT using backoff_counter_t directly
gvanrossum 1fe27c9
Rename increment,decrement to advance,pause
gvanrossum 225ea17
Give up on restricting backoff to <= 12
gvanrossum 63d8bc7
Rip out backoff thresholds
gvanrossum 8aa2c75
Fix tests
gvanrossum 7bd4daa
Fix initial temperature, clean up
gvanrossum 3f1c58a
Merge branch 'main' into exp-backoff
gvanrossum 8ce8068
Remove unused variable
gvanrossum 7bb5618
Admit defeat: advance_backoff_counter() may be entered when value == 0
gvanrossum 63e286c
Merge branch 'main' into exp-backoff
gvanrossum 7f64392
Merge remote-tracking branch 'origin/main' into exp-backoff
gvanrossum 8eee1b4
Put backoff field before value
gvanrossum 42c1f26
Small cleanup in .h files
gvanrossum a80cd0a
Rename DECREMENT_ADAPTIVE_COUNTER to ADVANCE_...
gvanrossum 545c60e
Rename ADAPTIVE_COUNTER_IS_ZERO to ..._TRIGGERS
gvanrossum 6c0bb30
Rename backoff_counter_is_zero to ..._triggers
gvanrossum a7c9b6d
Rename reset_background_counter to restart_...
gvanrossum 3fee35f
Make _Py_BackoffCounter a member of _Py_CODEUNIT
gvanrossum df6f34c
Refactor initial counter values.
gvanrossum 72f6b0d
Export tier 2 threshold from _testinternalcapi
gvanrossum dcee362
Merge remote-tracking branch 'origin/main' into exp-backoff
gvanrossum f38d922
Add news
gvanrossum ef6366b
Fix blurb formatting (I hope)
gvanrossum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Different approach to avoid incrementing bitmask in INSTRUMENTED_LINE
- Loading branch information
commit ce7726cb7431c6cf58c953943f55c1062ef0bcee
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.