8000 gh-117058: Update GUI and packaging recommendations for macOS. by freakboy3742 · Pull Request #117059 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117058: Update GUI and packaging recommendations for macOS. #117059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2024
Merged

gh-117058: Update GUI and packaging recommendations for macOS. #117059

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
decb8cf
Update GUI and packaging recommendations for macOS.
freakboy3742 Mar 20, 2024
df060a4
Removed news file.
freakboy3742 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed news file.
  • Loading branch information
@freakboy3742
freakboy3742 committed Mar 20, 2024
commit df060a4a102fd57dff2f88ffc4c906b5db0e0caf
2 changes: 0 additions & 2 deletions Misc/NEWS.d/next/Documentation/2024-03-20-12-58-00.gh-issue-117058.t-1AzS.rst
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this NEWS file, we usually don't include them for docs changes (ref).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems - removed.

Out of interest, is there a way to flag to Bevedere that there's no NEWS file requirement, or do we just live with the CI failure for that test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and now I see the reference to the skip-news label in Bevedere's message. I've added the label; feels like this would be a good addition to the dev guide (and/or the repo PR template?).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the devguide here: https://devguide.python.org/triage/labels/#labels-specific-to-prs

It could be useful PR template, but we need to strike a balance between informative and tl;dr. Feel free to propose something if you'd like 👍

This file was deleted.

0