8000 gh-113317: Change how Argument Clinic lists converters by vstinner · Pull Request #116853 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-113317: Change how Argument Clinic lists converters #116853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 27, 2024
Merged

gh-113317: Change how Argument Clinic lists converters #116853

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe8f906
gh-113317: Change how Argument Clinic lists converters
vstinner Mar 15, 2024
61fff9d
Fix mypy: add type annotations
vstinner Mar 15, 2024
7846792
Apply suggestions from code review
vstinner Mar 19, 2024
52da03c
Use proper types for converters and return converters
erlend-aasland Mar 22, 2024
dfce0e2
Update
vstinner Mar 22, 2024
44d6b5a
Fix create_parser_namespace()
vstinner Mar 22, 2024
9b98a8f
AnyConverterType
vstinner Mar 22, 2024
150e1db
Use @functools.cache
vstinner Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AnyConverterType
  • Loading branch information
@vstinner
vstinner committed Mar 22, 2024
commit 9b98a8f5bc6a4caff0c2f6422fe169145ba18bd8
6 changes: 3 additions & 3 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5008,9 +5008,9 @@ def run_clinic(parser: argparse.ArgumentParser, ns: argparse.Namespace) -> None:
parser.error(
"can't specify --converters and a filename at the same time"
)
any_converter_type = ConverterType | ReturnConverterType
converter_list: list[tuple[str, any_converter_type]] = []
return_converter_list: list[tuple[str, any_converter_type]] = []
AnyConverterType = ConverterType | ReturnConverterType
converter_list: list[tuple[str, AnyConverterType]] = []
return_converter_list: list[tuple[str, AnyConverterType]] = []

for name, converter in converters.items():
converter_list.append((
Expand Down
0