gh-116851: remove "from ctypes import *" from ctypes documents #116852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove import statement "from ctypes import *" from some code snippet before "libc", because "libc" cannot import ctypes, it cause ambiguous
|
All commit authors signed the Contributor License Agreement. |
serhiy-storchaka
approved these changes
Mar 15, 2024
|
Thanks @jnchen for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 16, 2024
…ythonGH-116852) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import. (cherry picked from commit 744c077) Co-authored-by: jnchen <caojingchen@live.com>
|
GH-116905 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 16, 2024
…ythonGH-116852) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import. (cherry picked from commit 744c077) Co-authored-by: jnchen <caojingchen@live.com>
|
GH-116906 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Mar 16, 2024
…GH-116852) (GH-116905) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import. (cherry picked from commit 744c077) Co-authored-by: jnchen <caojingchen@live.com>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Mar 16, 2024
…GH-116852) (GH-116906) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import. (cherry picked from commit 744c077) Co-authored-by: jnchen <caojingchen@live.com>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…ythonGH-116852) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…ythonGH-116852) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ythonGH-116852) It is confusing, because libc is not imported from ctypes, but defined in previous examples, which already contain the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove import statement "from ctypes import *" from some code snippet before "libc", because "libc" cannot import ctypes, it cause ambiguous
📚 Documentation preview 📚: https://cpython-previews--116852.org.readthedocs.build/