8000 gh-116780: Fix `test_inspect` in `-OO` mode by sobolevn · Pull Request #116788 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-116780: Fix test_inspect in -OO mode #116788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

gh-116780: Fix test_inspect in -OO mode #116788

merged 1 commit into from
Mar 14, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Mar 14, 2024 •
edited by bedevere-app bot
Loading

GitHub suggested me @serhiy-storchaka and @hauntsaninja as reviewers, could you please take a look? :)

@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 14, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 14, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 14, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn sobolevn merged commit f20dfb7 into python:main Mar 14, 2024
@bedevere-app bedevere-app bot 8000 removed the awaiting merge label Mar 14, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@sobolevn
Copy link
Member Author

Thank you! 👍

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f20dfb7569a769da50cd75f4932b9abe78e55d75 3.12

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f20dfb7569a769da50cd75f4932b9abe78e55d75 3.11

sobolevn added a commit to sobolevn/cpython that referenced this pull request Mar 14, 2024
@sobolevn
[3.12] pythongh-116780: Fix test_inspect in -OO mode (pythonGH-11…
303c3db 
…6788)
@bedevere-app
Copy link
bedevere-app bot commented Mar 14, 2024

GH-116799 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 14, 2024
sobolevn added a commit that referenced this pull request Mar 17, 2024
@sobolevn
[3.12] gh-116780: Fix test_inspect in -OO mode (GH-116788) (#116799)
2dbc77e
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn @vstinner
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
e9cdbfc
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @adorilson
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
430442e
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
2227362
@zware zware removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees

@sobolevn sobolevn

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @serhiy-storchaka @zware
0