10000 ghpython-116307: Proper fix for 'mod' leaking across importlib tests by jaraco · Pull Request #116678 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

ghpython-116307: Proper fix for 'mod' leaking across importlib tests #116678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 35 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
9b3f0f7
gh-116303: Skip some sqlite3 tests if testcapi is unavailable
erlend-aasland Mar 4, 2024
0f6f74e
Skip more tests
erlend-aasland Mar 4, 2024
2f750c3
Split up sqlite3 tests
erlend-aasland Mar 4, 2024
7c4477d
Amend previous commit
erlend-aasland Mar 4, 2024
a9c6f62
Pull in main
erlend-aasland Mar 4, 2024
cdc6df4
Use import_helper iso. requires_limited_api
erlend-aasland Mar 5, 2024
d05dcd7
More skips
erlend-aasland Mar 5, 2024
cb7cff4
Fix gc and weakref tests
erlend-aasland Mar 5, 2024
ad5e3b6
Remove local debug stuff
erlend-aasland Mar 5, 2024
cdb8bf4
Fix test_os
erlend-aasland Mar 5, 2024
e4a30b0
Fixup stable_abi.py
erlend-aasland Mar 5, 2024
fabb007
Fixup run_in_subinterp
erlend-aasland Mar 5, 2024
c51dafa
Fixup test_call
erlend-aasland Mar 5, 2024
c3f9c99
Fixup test_audit
erlend-aasland Mar 5, 2024
fde9548
Fix some _testsinglephase issues
erlend-aasland Mar 5, 2024
ea72ced
Address review: use setUpClass in test_call; don't skip everything
erlend-aasland Mar 5, 2024
628896c
Address review: no need to skip in tearDown
erlend-aasland Mar 5, 2024
88c6739
Address review: check import at the top of test_threading.test_frame_…
erlend-aasland Mar 5, 2024
c02cd6f
Fixup some test.support helpers
erlend-aasland Mar 5, 2024
d49532b
Fixup test_coroutines
erlend-aasland Mar 5, 2024
2427111
Fixup test_threading
erlend-aasland Mar 5, 2024
25d0999
Fixup test_repl
erlend-aasland Mar 5, 2024
bdd8cff
Fixup test_monitoring
erlend-aasland Mar 5, 2024
ee9fa51
Amend test_embed
erlend-aasland Mar 5, 2024
a47c5ff
Amend test_audit
erlend-aasland Mar 5, 2024
d84a5c4
Fix test_socket
erlend-aasland Mar 5, 2024
e877ffb
Resolve test_exceptions nicer
erlend-aasland Mar 5, 2024
1ec0c66
Merge branch 'main' into sqlite/testcapi
erlend-aasland Mar 5, 2024
afa58a9
Use import_helper in test_importlib
erlend-aasland Mar 5, 2024
760c6cb
Fixup test_embed
erlend-aasland Mar 5, 2024
d7f060a
Pull in main
erlend-aasland Mar 5, 2024
a1106b7
Revert spurious docs change
erlend-aasland Mar 5, 2024
db45852
Workaround: use a different test module name in test_module_resources
erlend-aasland Mar 5, 2024
bbb927a
gh-116307: Create a new import helper 'isolated modules' and use that…
jaraco Mar 6, 2024
369fcff
Merge branch 'sqlite/testcapi' of https://github.com/erlend-aasland/c…
jaraco Mar 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup some test.support helpers
  • Loading branch information
erlend-aasland committed Mar 5, 2024
commit c02cd6f10366d8b6da63dd6adbd68e22f47b500a
4 changes: 2 additions & 2 deletions Lib/test/support/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1707,7 +1707,7 @@ def run_in_subinterp(code):
try:
import _testcapi
except ImportError:
raise SkipTest("requires _testcapi")
raise unittest.SkipTest("requires _testcapi")
return _testcapi.run_in_subinterp(code)


57BC Expand All @@ -1720,7 +1720,7 @@ def run_in_subinterp_with_config(code, *, own_gil=None, **config):
try:
import _testinternalcapi
except ImportError:
raise SkipTest("requires _testinternalcapi")
raise unittest.SkipTest("requires _testinternalcapi")
if own_gil is not None:
assert 'gil' not in config, (own_gil, config)
config['gil'] = 2 if own_gil else 1
Expand Down
0