8000 gh-71042: Add `platform.android_ver` by mhsmith · Pull Request #116674 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-71042: Add platform.android_ver #116674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 27, 2024
Merged

gh-71042: Add platform.android_ver #116674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ead6dcb
Add `platform.android_ver`
mhsmith Mar 12, 2024
8934a4e
Documentation fixes
mhsmith Mar 12, 2024
4dca7c4
Skip UDPLITE tests before API level 29
mhsmith Mar 13, 2024
4108dfc
Clarify model and device name documentation
mhsmith Mar 25, 2024
646441b
Remove min_api_level field
mhsmith Mar 25, 2024
4f65e8e
Add is_emulator field
mhsmith Mar 26, 2024
9fd7f44
Apply suggestions from code review
mhsmith Mar 26, 2024
b64f1f5
Apply suggestions from code review
mhsmith Mar 27, 2024
53e6511
Clarify distinction between platform.android_ver().api_level and sys.…
mhsmith Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@mhsmith @vstinner
mhsmith and vstinner authored Mar 27, 2024
commit b64f1f5e34b55995c83d442ff9d2946e9abccdb3
8 changes: 4 additions & 4 deletions Doc/library/platform.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,21 +317,21 @@ Android Platform

* ``api_level`` - API level, as an integer (e.g. ``34``)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to repeat here the difference with https://docs.python.org/dev/library/sys.html#sys.getandroidapilevel and so add a reference to the sys function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea; done.


* ``manufacturer`` - `manufacturer name
* ``manufacturer`` - `Manufacturer name
<https://developer.android.com/reference/android/os/Build#MANUFACTURER>`__

* ``model`` - `model name
* ``model`` - `Model name
<https://developer.android.com/reference/android/os/Build#MODEL>`__ –
typically the marketing name or model number

* ``device`` - `device name
* ``device`` - `Device name
<https://developer.android.com/reference/android/os/Build#DEVICE>`__ –
typically the model number or a codename

* ``is_emulator`` - ``True`` if the device is an emulator; ``False`` if it's
a physical device

For a list of known model and device names, see `here
See the `list of known model and device names
<https://storage.googleapis.com/play_public/supported_devices.html>`__.

.. versionadded:: 3.13
2 changes: 1 addition & 1 deletion Lib/test/support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,7 +1795,7 @@ def missing_compiler_executable(cmd_names=[]):
def setswitchinterval(interval):
# Setting a very low gil interval on the Android emulator causes python
# to hang (issue #26939).
minimum_interval = 1e-4
minimum_interval = 1e-4 # 100 us
if is_android and interval < minimum_interval:
global _old_android_emulator
if _old_android_emulator is None:
Expand Down
0