8000 gh-116604: Correctly honor the gc status when calling _Py_RunGC by pablogsal · Pull Request #116628 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-116604: Correctly honor the gc status when calling _Py_RunGC #116628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

gh-116604: Correctly honor the gc status when calling _Py_RunGC #116628

merged 1 commit into from
Mar 12, 2024

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented Mar 11, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 11, 2024
Closed
@pablogsal pablogsal added the needs backport to 3.12 only security fixes label Mar 11, 2024
@pablogsal
pythongh-116604: Correctly honor the gc status when calling _Py_RunGC
7e1973c 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@wjakob
Copy link
Contributor
wjakob commented Mar 12, 2024 •
edited
Loading

Perfect, this looks good to me and solves the issue I encountered.

For 3.12, the patch has to be adapted because the implementation of _Py_RunGC isn't exactly the same.

@pablogsal Besides 3.13, could this be pulled into the next Patch release of 3.12?

@pablogsal
Copy link
Member Author

Yup I will back port to 3.12 don't worry

@pablogsal pablogsal merged commit 02918aa into python:main Mar 12, 2024
@pablogsal pablogsal deleted the gh-116604 branch March 12, 2024 12:00
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 02918aa96117781261cb1a564e37a861b01eb883 3.12

@bedevere-app
Copy link
bedevere-app bot commented Mar 12, 2024

GH-116653 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 12, 2024
pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 12, 2024
@pablogsal
[3.12] pythongh-116604: Correctly honor the gc status when calling _P…
d39d5e4 
…y_RunGC (pythonGH-116628)

(cherry picked from commit 02918aa)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 12, 2024
@pablogsal
[3.12] pythongh-116604: Correctly honor the gc status when calling _P…
dcfb21d 
…y_RunGC (pythonGH-116628) (python#116653)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@pablogsal @adorilson
pythongh-116604: Correctly honor the gc status when calling _Py_RunGC (…
dae8f5a 
…python#116628)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@pablogsal @diegorusso
pythongh-116604: Correctly honor the gc status when calling _Py_RunGC (…
bb10652 
…python#116628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @wjakob @erlend-aasland
0