8000 Replace stat.ST_xxx usage with os.stat().st_xxx by vstinner · Pull Request #116501 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Replace sta 8000 t.ST_xxx usage with os.stat().st_xxx #116501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Mar 8, 2024

Modernize code to use the new API which avoids the usage of the stat module just to read os.stat() members.

  • Sort logging.handlers imports.
  • Rework reopenIfNeeded() code to make it easier to follow.

@vstinner
Copy link
Member Author
vstinner commented Mar 8, 2024

cc @serhiy-storchaka @sobolevn

Modernize code to use the new API which avoids the usage of the stat
module just to read os.stat() members.

* Sort logging.handlers imports.
* Rework reopenIfNeeded() code to make it easier to follow.
* Replace "not self.stream" with "self.stream is None".
@vstinner
Copy link
Member Author
vstinner commented Mar 8, 2024

@serhiy-storchaka: I updated the PR to address your review. Please review the updated PR ;-)

@vstinner vstinner merged commit 6183158 into python:main Mar 8, 2024
@vstinner vstinner deleted the modernize_stat branch March 8, 2024 17:49
@vstinner
Copy link
Member Author
vstinner commented Mar 8, 2024

Merged, thanks for the review @serhiy-storchaka.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
Modernize code to use the new API which avoids the usage of the stat
module just to read os.stat() members.

* Sort logging.handlers imports.
* Rework reopenIfNeeded() code to make it easier to follow.
* Replace "not self.stream" with "self.stream is None".
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Modernize code to use the new API which avoids the usage of the stat
module just to read os.stat() members.

* Sort logging.handlers imports.
* Rework reopenIfNeeded() code to make it easier to follow.
* Replace "not self.stream" with "self.stream is None".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0