8000 gh-116167: Allow disabling the GIL with `PYTHON_GIL=0` or `-X gil=0` by swtaarrs · Pull Request #116338 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-116167: Allow disabling the GIL with PYTHON_GIL=0 or -X gil=0 #116338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 11, 2024
Merged

gh-116167: Allow disabling the GIL with PYTHON_GIL=0 or -X gil=0 #116338

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9e03999
Allow disabling the GIL with `PYTHON_GIL=0`
swtaarrs Mar 1, 2024
a53ed2e
Don't add 'enable_gil' to test_embed in normal builds
swtaarrs Mar 5, 2024
e0b8484
Set enable_gil properly when PYTHON_GIL=1
swtaarrs Mar 5, 2024
4f43a87
Add test for PYTHON_GIL in test_cmd_line
swtaarrs Mar 5, 2024
9e9d925
Fix else brace formatting
swtaarrs Mar 6, 2024
5053661
Document PYTHON_GIL environment variable
swtaarrs Mar 5, 2024
6d62fbb
Merge remote-tracking branch 'upstream/main' into HEAD
swtaarrs Mar 7, 2024
971a9a1
Add `-X gil` option, add to `sys.flags`, modify test to cover env var…
swtaarrs Mar 7, 2024
89b1150
Fix link to `-X gil`
swtaarrs Mar 7, 2024
16fbd44
Fix PYTHON_GIL versionchanged line
swtaarrs Mar 7, 2024
8d39bbc
Clarify test_flags in normal builds
swtaarrs Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for PYTHON_GIL in test_cmd_line
  • Loading branch information
@swtaarrs
swtaarrs committed Mar 5, 2024
commit 4f43a87ea9b80c210c9f70793a190a2c6f85c0f2
32 changes: 32 additions & 0 deletions Lib/test/test_cmd_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,38 @@ def test_pythondevmode_env(self):
self.assertEqual(proc.stdout.rstrip(), 'True')
self.assertEqual(proc.returncode, 0, proc)

@unittest.skipUnless(support.Py_GIL_DISABLED,
"PYTHON_GIL only supported in Py_GIL_DISABLED builds")
def test_python_gil_env(self):
code = """if 1:
import _testinternalcapi
print(_testinternalcapi.get_configs()['config'].get('enable_gil'))
"""
args = [sys.executable, '-c', code]
env = dict(os.environ)
env.pop('PYTHON_GIL', None)

def run():
return subprocess.run(args, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, text=True, env=env)

proc = run()
self.assertEqual(proc.returncode, 0, proc)
self.assertEqual(proc.stdout.rstrip(), '0')
self.assertEqual(proc.stderr, '')

env['PYTHON_GIL'] = '0'
proc = run()
self.assertEqual(proc.returncode, 0, proc)
self.assertEqual(proc.stdout.rstrip(), '1')
self.assertEqual(proc.stderr, '')

env['PYTHON_GIL'] = '1'
proc = run()
self.assertEqual(proc.returncode, 0, proc)
self.assertEqual(proc.stdout.rstrip(), '2')
self.assertEqual(proc.stderr, '')

@unittest.skipUnless(sys.platform == 'win32',
'bpo-32457 only applies on Windows')
def test_argv0_normalization(self):
Expand Down
0