-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-35782: Fix error message in randrange #11620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Thanks for the PR. The change looks good to me and I hope it doesn't require tests for the message change. Please sign the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted image
@tirkarthi I've signed the CLA, I guess it'll take a day to update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eyes! LGTM.
@asottile please don't use pictures (especially animated GIFs) on the tracker. |
@kakshay21 please ping me if the PR will not land in a three days |
@asvetlov apologies, it's an automated user script and not intended to gain attention, just for good fun |
Thanks @kakshay21 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-11640 is a backport of this pull request to the 3.7 branch. |
https://bugs.python.org/issue35782 (cherry picked from commit 2433a2a) Co-authored-by: Kumar Akshay <k.akshay9721@gmail.com>
https://bugs.python.org/issue35782