8000 bpo-35782: Fix error message in randrange by kakshay21 · Pull Request #11620 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-35782: Fix error message in randrange #11620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

bpo-35782: Fix error message in randrange #11620

merged 1 commit into from
Jan 21, 2019

Conversation

kakshay21
Copy link
Contributor
@kakshay21 kakshay21 commented Jan 19, 2019 •
edited by bedevere-bot
Loading

@kakshay21 kakshay21 requested a review from rhettinger as a code owner January 19, 2019 08:57
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

Thanks for the PR. The change looks good to me and I hope it doesn't require tests for the message change. Please sign the CLA.

asottile
asottile approved these changes Jan 19, 2019
View reviewed changes
Copy link
Contributor
@asottile asottile left a comment •
edited by asvetlov
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted image

@kakshay21
Copy link
Contributor Author

@tirkarthi I've signed the CLA, I guess it'll take a day to update.

eamanu
eamanu approved these changes Jan 19, 2019
View reviewed changes
Copy link
Contributor
@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes! LGTM.

@asvetlov
Copy link
Contributor

@asottile please don't use pictures (especially animated GIFs) on the tracker.
It hurt my eyes, both in an e-mail client and this review.
I understand the striving to get the PR merged but please...

@asvetlov
Copy link
Contributor

@kakshay21 please ping me if the PR will not land in a three days

@asottile
Copy link
Contributor

@asvetlov apologies, it's an automated user script and not intended to gain attention, just for good fun

@miss-islington miss-islington merged commit 2433a2a into python:master Jan 21, 2019
@miss-islington
Copy link
Contributor

Thanks @kakshay21 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11640 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2019
@kakshay21 @miss-islington
bpo-35782: Fix error message in randrange (pythonGH-11620)
2c8649c 
https://bugs.python.org/issue35782
(cherry picked from commit 2433a2a)

Co-authored-by: Kumar Akshay <k.akshay9721@gmail.com>
@kakshay21 kakshay21 deleted the fix-issue-35782 branch January 21, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@asottile asottile asottile approved these changes

@eamanu eamanu eamanu approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kakshay21 @the-knights-who-say-ni @tirkarthi @asvetlov @asottile @miss-islington @bedevere-bot @eamanu
0