8000 gh-115961: Improve tests for compressed file-like objects by serhiy-storchaka · Pull Request #115963 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-115961: Improve tests for compressed file-like objects #115963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2024
Merged

gh-115961: Improve tests for compressed file-like objects #115963

merged 3 commits into from
Feb 28, 2024

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Feb 26, 2024 •
edited by bedevere-app bot
Loading
  • Increase coverage for compressed file-like objects initialized with a file name, an open file object, a file object opened by file descriptor, and a file-like object without name and mode attributes (io.BytesIO)
  • Increase coverage for name, fileno(), mode, readable(), writable(), seekable() in different modes and states
  • No longer skip tests with bytes names
  • Test objects implementing the path protocol, not just pathlib.Path.

@serhiy-storchaka
pythongh-115961: Improve tests for compressed file-like objects
f5955ba 
* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 26, 2024
@bedevere-app bedevere-app bot mentioned this pull request Feb 26, 2024
Closed
serhiy-storchaka
serhiy-storchaka commented Feb 28, 2024
View reviewed changes
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 28, 2024 07:26
@serhiy-storcha 8000 ka serhiy-storchaka merged commit e72576c into python:main Feb 28, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2024
@serhiy-storchaka @miss-islington
pythongh-115961: Improve tests for compressed file-like objects (pyth…
86718b5 
…onGH-115963)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
(cherry picked from commit e72576c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e72576c48b8be1e4f22c2f387f9769efa073c5be 3.11

@bedevere-app
Copy link
bedevere-app bot commented Feb 28, 2024

GH-116032 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 28, 2024
serhiy-storchaka added a commit that referenced this pull request Feb 28, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-115961: Improve tests for compressed file-like objects (GH-…
e5e9862 
…115963) (GH-116032)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
(cherry picked from commit e72576c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the test-compress-file-attrs branch February 28, 2024 09:01
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.12 has failed when building commit e5e9862.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1102/builds/730) and take a look at the build logs.
  4. Check if the failure is related to this commit (e5e9862) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1102/builds/730

Failed tests:

  • test_socket

Failed subtests:

  • test_idna - test.test_socket.GeneralModuleTests.test_idna

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test_socket.py", line 1669, in test_idna
    socket.gethostbyname(domain)
socket.gaierror: [Errno -2] Name or service not known

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 28, 2024
@serhiy-storchaka
[3.11] pythongh-115961: Improve tests for compressed file-like objects (
7f57079 
pythonGH-115963)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes a
8000
nd states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
(cherry picked from commit e72576c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 28, 2024

GH-116039 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 28, 2024
serhiy-storchaka added a commit that referenced this pull request Feb 28, 2024
@serhiy-storchaka
[3.11] gh-115961: Improve tests for compressed file-like objects (GH-…
becc615 
…115963) (GH-116039)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
(cherry picked from commit e72576c)
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@serhiy-storchaka @woodruffw
pythongh-115961: Improve tests for compressed file-like objects (pyth…
d280d6e 
…onGH-115963)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@serhiy-storchaka @adorilson
pythongh-115961: Improve tests for compressed file-like objects (pyth…
44286f7 
…onGH-115963)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-115961: Improve tests for compressed file-like objects (pyth…
f8da870 
…onGH-115963)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @bedevere-bot
0