8000 gh-76785: Update test.support.interpreters to Align With PEP 734 by ericsnowcurrently · Pull Request #115566 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-76785: Update test.support.interpreters to Align With PEP 734 #115566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Interpreter.exec_sync() -> exec().
  • Loading branch information
ericsnowcurrently committed Feb 27, 2024
commit 52cfcfb2217f7b2138ef59cb9f1a8e748f50ae06
4 changes: 2 additions & 2 deletions Lib/test/support/interpreters/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def prepare_main(self, ns=None, /, **kwargs):
ns = dict(ns, **kwargs) if ns is not None else kwargs
_interpreters.set___main___attrs(self._id, ns)

def exec_sync(self, code, /):
def exec(self, code, /):
"""Run the given source code in the interpreter.

This is essentially the same as calling the builtin "exec"
Expand All @@ -182,7 +182,7 @@ def exec_sync(self, code, /):

def run(self, code, /):
def task():
self.exec_sync(code)
self.exec(code)
t = threading.Thread(target=task)
t.start()
return t
46 changes: 23 additions & 23 deletions Lib/test/test_interpreters/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def test_subinterpreter(self):
def test_finished(self):
r, w = self.pipe()
interp = interpreters.create()
interp.exec_sync(f"""if True:
interp.exec(f"""if True:
import os
os.write({w}, b'x')
""")
Expand Down Expand Up @@ -312,7 +312,7 @@ def test_with_only_background_threads(self):
FINISHED = b'F'

interp = interpreters.create()
interp.exec_sync(f"""if True:
interp.exec(f"""if True:
import os
import threading

Expand All @@ -326,7 +326,7 @@ def task():
self.assertFalse(interp.is_running())

os.write(w_thread, DONE)
interp.exec_sync('t.join()')
interp.exec('t.join()')
self.assertEqual(os.read(r_interp, 1), FINISHED)


Expand Down Expand Up @@ -393,7 +393,7 @@ def test_from_sibling(self):
interp2 = interpreters.create()
8000 self.assertEqual(set(interpreters.list_all()),
{main, interp1, interp2})
interp1.exec_sync(dedent(f"""
interp1.exec(dedent(f"""
from test.support import interpreters
interp2 = interpreters.Interpreter({interp2.id})
interp2.close()
Expand Down Expand Up @@ -427,7 +427,7 @@ def test_subthreads_still_running(self):
FINISHED = b'F'

interp = interpreters.create()
interp.exec_sync(f"""if True:
interp.exec(f"""if True:
import os
import threading
import time
Expand Down Expand Up @@ -504,9 +504,9 @@ def test_not_shareable(self):

# Make sure neither was actually bound.
with self.assertRaises(interpreters.ExecFailure):
interp.exec_sync('print(foo)')
interp.exec('print(foo)')
with self.assertRaises(interpreters.ExecFailure):
interp.exec_sync('print(spam)')
interp.exec('print(spam)')


class TestInterpreterExecSync(TestBase):
Expand All @@ -515,15 +515,15 @@ def test_success(self):
interp = interpreters.create()
script, file = _captured_script('print("it worked!", end="")')
with file:
interp.exec_sync(script)
interp.exec(script)
out = file.read()

self.assertEqual(out, 'it worked!')

def test_failure(self):
interp = interpreters.create()
with self.assertRaises(interpreters.ExecFailure):
interp.exec_sync('raise Exception')
interp.exec('raise Exception')

def test_display_preserved_exception(self):
tempdir = self.temp_dir()
Expand All @@ -542,18 +542,18 @@ def script():
spam.eggs()

interp = interpreters.create()
interp.exec_sync(script)
interp.exec(script)
""")

stdout, stderr = self.assert_python_failure(scriptfile)
self.maxDiff = None
interpmod_line, = (l for l in stderr.splitlines() if ' exec_sync' in l)
# File "{interpreters.__file__}", line 179, in exec_sync
interpmod_line, = (l for l in stderr.splitlines() if ' exec' in l)
# File "{interpreters.__file__}", line 179, in exec
self.assertEqual(stderr, dedent(f"""\
Traceback (most recent call last):
File "{scriptfile}", line 9, in <module>
interp.exec_sync(script)
~~~~~~~~~~~~~~~~^^^^^^^^
interp.exec(script)
~~~~~~~~~~~^^^^^^^^
{interpmod_line.strip()}
raise ExecFailure(excinfo)
test.support.interpreters.ExecFailure: RuntimeError: uh-oh!
Expand All @@ -578,7 +578,7 @@ def test_in_thread(self):
script, file = _captured_script('print("it worked!", end="")')
with file:
def f():
interp.exec_sync(script)
interp.exec(script)

t = threading.Thread(target=f)
t.start()
Expand All @@ -604,7 +604,7 @@ def test_fork(self):
with open('{file.name}', 'w', encoding='utf-8') as out:
out.write('{expected}')
""")
interp.exec_sync(script)
interp.exec(script)

file.seek(0)
content = file.read()
Expand All @@ -615,17 +615,17 @@ def test_already_running(self):
interp = interpreters.create()
with _running(interp):
with self.assertRaises(RuntimeError):
interp.exec_sync('print("spam")')
interp.exec('print("spam")')

def test_bad_script(self):
interp = interpreters.create()
with self.assertRaises(TypeError):
interp.exec_sync(10)
interp.exec(10)

def test_bytes_for_script(self):
interp = interpreters.create()
with self.assertRaises(TypeError):
interp.exec_sync(b'print("spam")')
interp.exec(b'print("spam")')

def test_with_background_threads_still_running(self):
r_interp, w_interp = self.pipe()
Expand All @@ -636,7 +636,7 @@ def test_with_background_threads_still_running(self):
FINISHED = b'F'

interp = interpreters.create()
interp.exec_sync(f"""if True:
interp.exec(f"""if True:
import os
import threading

Expand All @@ -648,18 +648,18 @@ def task():
t.start()
os.write({w_interp}, {RAN!r})
""")
interp.exec_sync(f"""if True:
interp.exec(f"""if True:
os.write({w_interp}, {RAN!r})
""")

os.write(w_thread, DONE)
interp.exec_sync('t.join()')
interp.exec('t.join()')
self.assertEqual(os.read(r_interp, 1), RAN)
self.assertEqual(os.read(r_interp, 1), RAN)
self.assertEqual(os.read(r_interp, 1), FINISHED)

# test_xxsubinterpreters covers the remaining
# Interpreter.exec_sync() behavior.
# Interpreter.exec() behavior.


class TestInterpreterRun(TestBase):
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_interpreters/test_channels.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def test_send_recv_main(self):

def test_send_recv_same_interpreter(self):
interp = interpreters.create()
interp.exec_sync(dedent("""
interp.exec(dedent("""
from test.support.interpreters import channels
r, s = channels.create()
orig = b'spam'
Expand Down Expand Up @@ -193,7 +193,7 @@ def test_send_recv_nowait_main_with_default(self):

def test_send_recv_nowait_same_interpreter(self):
interp = interpreters.create()
interp.exec_sync(dedent("""
interp.exec(dedent("""
from test.support.interpreters import channels
r, s = channels.create()
orig = b'spam'
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_interpreters/test_lifecycle.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_sys_path_0(self):
orig = sys.path[0]

interp = interpreters.create()
interp.exec_sync(f"""if True:
interp.exec(f"""if True:
import json
import sys
print(json.dumps({{
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_interpreters/test_queues.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_shareable(self):
queue1 = queues.create()

interp = interpreters.create()
interp.exec_sync(dedent(f"""
interp.exec(dedent(f"""
from test.support.interpreters import queues
queue1 = queues.Queue({queue1.id})
"""));
Expand Down Expand Up @@ -281,7 +281,7 @@ def test_put_get_default_not_sharedonly(self):

def test_put_get_same_interpreter(self):
interp = interpreters.create()
interp.exec_sync(dedent("""
interp.exec(dedent("""
from test.support.interpreters import queues
queue = queues.create()
orig = b'spam'
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_interpreters/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ def _run_output(interp, request, init=None):
with rpipe:
if init:
interp.prepare_main(init)
interp.exec_sync(script)
interp.exec(script)
return rpipe.read()


@contextlib.contextmanager
def _running(interp):
r, w = os.pipe()
def run():
interp.exec_sync(dedent(f"""
interp.exec(dedent(f"""
# wait for "signal"
with open({r}) as rpipe:
rpipe.read()
Expand Down
0