gh-115490: Work around test.support.interpreters.channels not handling unloading #115515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, which regrtest does when running tests sequentially, by explicitly skipping the unloading of test.support.interpreters and its submodules. This can be rolled back once test.support.interpreters.channels supports unloading, if we are keeping sequential runs in the same process around.
vstinner
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
LGTM.
@ericsnowcurrently: test_interpreters should do something about that in a tearDownModule() function, or find a workaround, rather than having to use such hack in regrtest :-(
I approve this PR to unblock Python 3.13 alpha4 release.
serhiy-storchaka
approved these changes
Feb 15, 2024
|
@ericsnowcurrently: Is Python 3.12 affected? |
|
No. test_interpreters.test_channels doesn't exist in 3.12, and running test_interpreters twice in the same process doesn't show any issues: |
For the record, that fix is here: #115493 |
Thanks for the confirmation. |
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
Mar 4, 2024
…ls not handling unloading (python#115515)" This reverts commit b0e5c35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around test.support.interpreters.channels not handling unloading, which regrtest does when running tests sequentially, by explicitly skipping the unloads of test.support.interpreters and its submodules.
This can be rolled back once test.support.interpreters.channels supports unloading, if we are keeping sequential runs in the same process around.