8000 gh-115317: Rewrite changelog filter to use vanilla JavaScript by hugovk · Pull Request #115324 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-115317: Rewrite changelog filter to use vanilla JavaScript #115324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2024
Merged

gh-115317: Rewrite changelog filter to use vanilla JavaScript #115324

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f5071d
Rewrite using vanilla JavaScript
hugovk Feb 12, 2024
e8c055c
Re-add comments
hugovk Feb 12, 2024
b38d840
Add braces
hugovk Feb 12, 2024
b96383a
Prefer const
hugovk Feb 12, 2024
a926364
Format with Prettier
hugovk Feb 12, 2024
dc1f94d
Use camelCase for function name
hugovk Feb 12, 2024
cccf0a7
Prefer const
hugovk Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use camelCase for function name 
For example:

https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Writing_style_guide/Code_style_guide/JavaScript#functions
  • Loading branch information
@hugovk
hugovk committed Feb 12, 2024
commit dc1f94daac0f4da06e0ca6bc5d9697db29798915
6 changes: 3 additions & 3 deletions Doc/tools/static/changelog_search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ document.addEventListener("DOMContentLoaded", function () {
].join("\n"),
);

function dofilter() {
function doFilter() {
let query;
try {
query = new RegExp(document.querySelector("#searchbox").value, "i");
Expand Down Expand Up @@ -52,8 +52,8 @@ document.addEventListener("DOMContentLoaded", function () {
}
}
}
document.querySelector("#searchbox").addEventListener("keyup", dofilter);
document.querySelector("#searchbox").addEventListener("keyup", doFilter);
document
.querySelector("#searchbox-submit")
.addEventListener("click", dofilter);
.addEventListener("click", doFilter);
});
0