gh-115315: Update time.rst to include microseconds field (%f) in chart #115316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation on microseconds and the %f field.
|
All commit authors signed the Contributor License Agreement. |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Made changes on table with note regarding strptime and strftime per conversation with Hugo.
hugovk
reviewed
Feb 12, 2024
Thanks for the tweaks! Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
reviewed
Feb 12, 2024
Thanks you Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thanks! I think this is ready for the other reviewers?Sent from my iPhoneOn Feb 12, 2024, at 11:17, Hugo van Kemenade ***@***.***> wrote:
@hugovk commented on this pull request.
In Doc/library/time.rst:
+ (3)
+ The ``%f` format directive only applies to :func:`strptime`,
+ not to :func:`strftime`.
+ However, see also :meth:`datetime.strptime` and
+ :meth:`datetime.strftime`.
Sorry, I missed a backtick, and we need the full ref for datetime:
⬇️ Suggested change
- (3)
- The ``%f` format directive only applies to :func:`strptime`,
- not to :func:`strftime`.
- However, see also :meth:`datetime.strptime` and
- :meth:`datetime.strftime`.
+ (3)
+ The ``%f`` format directive only applies to :func:`strptime`,
+ not to :func:`strftime`.
+ However, see also :meth:`datetime.datetime.strptime` and
+ :meth:`datetime.datetime.strftime`.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
hugovk
reviewed
Feb 13, 2024
Made changes requested to put the datetime references in better context.
hugovk
approved these changes
Feb 13, 2024
|
Ok, thank you!Sent from my iPhoneOn Feb 13, 2024, at 14:44, Hugo van Kemenade ***@***.***> wrote:
@hugovk approved this pull request.
Thanks!
Let's give some time for the CODEOWNERS to review before merging.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This comment was marked as duplicate.
This comment was marked as duplicate.
willingc
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Thanks @TahomaSoft. While we wait on feedback from the CODEOWNERS, it would be good to follow the alphabetical pattern of the table and move %f up in the table.
|
Will do!
|
…mbers and sequentce to match
|
Thanks @TahomaSoft for making the change and clarification. @hugovk Do we still want to wait for CODEOWNERS on this doc PR or go ahead and merge? I think either would be fine. |
willingc
approved these changes
Feb 26, 2024
|
Let's merge. I think two weeks is long enough, we can easily make new changes later. Thanks! |
|
Thanks @TahomaSoft for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2024
…n chart (pythonGH-115316) (cherry picked from commit 3a72fc3) Co-authored-by: Tahoma Software <bacon@tahoma.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-115990 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2024
…n chart (pythonGH-115316) (cherry picked from commit 3a72fc3) Co-authored-by: Tahoma Software <bacon@tahoma.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-115991 is a backport of this pull request to the 3.11 branch. |
hugovk
added a commit
that referenced
this pull request
Feb 27, 2024
hugovk
added a commit
that referenced
this pull request
Feb 27, 2024
|
Thanks All! Happy to have been able to contribute. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…n chart (python#115316) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…n chart (python#115316) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…n chart (python#115316) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation on microseconds and the %f field.
📚 Documentation preview 📚: https://cpython-previews--115316.org.readthedocs.build/en/115316/library/time.html