-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-115315: Update time.rst to include microseconds field (%f) in chart #115316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added documentation on microseconds and the %f field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #115315 (comment).
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Made changes on table with note regarding strptime and strftime per conversation with Hugo.
Thanks for the tweaks! Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Thanks you Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Thanks! I think this is ready for the other reviewers?Sent from my iPhoneOn Feb 12, 2024, at 11:17, Hugo van Kemenade ***@***.***> wrote:
@hugovk commented on this pull request.
In Doc/library/time.rst:
+ (3)
+ The ``%f` format directive only applies to :func:`strptime`,
+ not to :func:`strftime`.
+ However, see also :meth:`datetime.strptime` and
+ :meth:`datetime.strftime`.
Sorry, I missed a backtick, and we need the full ref for datetime:
⬇️ Suggested change
- (3)
- The ``%f` format directive only applies to :func:`strptime`,
- not to :func:`strftime`.
- However, see also :meth:`datetime.strptime` and
- :meth:`datetime.strftime`.
+ (3)
+ The ``%f`` format directive only applies to :func:`strptime`,
+ not to :func:`strftime`.
+ However, see also :meth:`datetime.datetime.strptime` and
+ :meth:`datetime.datetime.strftime`.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Made changes requested to put the datetime references in better context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Let's give some time for the CODEOWNERS to review before merging.
Ok, thank you!Sent from my iPhoneOn Feb 13, 2024, at 14:44, Hugo van Kemenade ***@***.***> wrote:
@hugovk approved this pull request.
Thanks!
Let's give some time for the CODEOWNERS to review before merging.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This comment was marked as duplicate.
This comment was marked as duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TahomaSoft. While we wait on feedback from the CODEOWNERS, it would be good to follow the alphabetical pattern of the table and move %f
up in the table.
Will do!
|
…mbers and sequentce to match
Thanks @TahomaSoft for making the change and clarification. @hugovk Do we still want to wait for CODEOWNERS on this doc PR or go ahead and merge? I think either would be fine. |
Let's merge. I think two weeks is long enough, we can easily make new changes later. Thanks! |
Thanks @TahomaSoft for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…n chart (pythonGH-115316) (cherry picked from commit 3a72fc3) Co-authored-by: Tahoma Software <bacon@tahoma.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-115990 is a backport of this pull request to the 3.12 branch. |
…n chart (pythonGH-115316) (cherry picked from commit 3a72fc3) Co-authored-by: Tahoma Software <bacon@tahoma.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-115991 is a backport of this pull request to the 3.11 branch. |
Thanks All! Happy to have been able to contribute. |
…n chart (python#115316) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…n chart (python#115316) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…n chart (python#115316) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Added documentation on microseconds and the %f field.
📚 Documentation preview 📚: https://cpython-previews--115316.org.readthedocs.build/en/115316/library/time.html