8000 gh-115315: Update time.rst to include microseconds field (%f) in chart by TahomaSoft · Pull Request #115316 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-115315: Update time.rst to include microseconds field (%f) in chart #115316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 27, 2024
Merged

gh-115315: Update time.rst to include microseconds field (%f) in chart #115316

merged 10 commits into from
Feb 27, 2024

Conversation

TahomaSoft
Copy link
Contributor
@TahomaSoft TahomaSoft commented Feb 12, 2024

Added documentation on microseconds and the %f field.
@ghost
Copy link
ghost commented Feb 12, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 12, 2024
@hugovk hugovk changed the title gh-115315: Update time.rst to include microseconds field (%f) in chart . gh-115315: Update time.rst to include microseconds field (%f) in chart Feb 12, 2024
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #115315 (comment).

TahomaSoft and others added 3 commits February 12, 2024 09:00
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Made changes on table with note regarding strptime and strftime per conversation with Hugo.
Thanks for the tweaks!

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
TahomaSoft and others added 3 commits February 12, 2024 11:24
Thanks you

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@TahomaSoft
Copy link
Contributor Author
TahomaSoft commented Feb 12, 2024 via email

Made changes requested to put the datetime references in better context.
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's give some time for the CODEOWNERS to review before merging.

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 13, 2024
@TahomaSoft
Copy link
Contributor Author
TahomaSoft commented Feb 14, 2024 via email

@TahomaSoft

This comment was marked as duplicate.

Copy link
Contributor
@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TahomaSoft. While we wait on feedback from the CODEOWNERS, it would be good to follow the alphabetical pattern of the table and move %f up in the table.

@TahomaSoft
Copy link
Contributor Author

Will do!

Thanks @TahomaSoft. While we wait on feedback from the CODEOWNERS, it would be good to follow the alphabetical pattern of the table and move %f up in the table.

@willingc
Copy link
Contributor

Thanks @TahomaSoft for making the change and clarification.

@hugovk Do we still want to wait for CODEOWNERS on this doc PR or go ahead and merge? I think either would be fine.

@hugovk
Copy link
Member
hugovk commented Feb 27, 2024

Let's merge. I think two weeks is long enough, we can easily make new changes later.

Thanks!

@hugovk hugovk merged commit 3a72fc3 into python:main Feb 27, 2024
@miss-islington-app
Copy link

Thanks @TahomaSoft for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2024
…n chart (pythonGH-115316)

(cherry picked from commit 3a72fc3)

Co-authored-by: Tahoma Software <bacon@tahoma.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 27, 2024

GH-115990 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2024
…n chart (pythonGH-115316)

(cherry picked from commit 3a72fc3)

Co-authored-by: Tahoma Software <bacon@tahoma.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 27, 2024

GH-115991 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 27, 2024
hugovk added a commit that referenced this pull request Feb 27, 2024
…in chart (GH-115316) (#115990)

Co-authored-by: Tahoma Software <bacon@tahoma.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Feb 27, 2024
…in chart (GH-115316) (#115991)

Co-authored-by: Tahoma Software <bacon@tahoma.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@TahomaSoft TahomaSoft deleted the time-doc branch February 27, 2024 21:28
@TahomaSoft
Copy link
Contributor Author

Thanks All! Happy to have been able to contribute.

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…n chart (python#115316)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…n chart (python#115316)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…n chart (python#115316)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0