8000 gh-115285: Fix `test_dataclasses` with `-OO` mode by sobolevn · Pull Request #115286 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-115285: Fix test_dataclasses with -OO mode #115286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2024
Merged

gh-115285: Fix test_dataclasses with -OO mode #115286

merged 2 commits into from
Feb 12, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Feb 11, 2024 •
edited by bedevere-app bot
Loading

After it passes with both modes:

» ./python.exe -OO Lib/test/test_dataclasses/__init__.py
............................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 236 tests in 0.230s

OK

» ./python.exe Lib/test/test_dataclasses/__init__.py    
............................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 236 tests in 0.229s

OK

@sobolevn sobolevn requested a review from ericvsmith as a code owner February 11, 2024 09:26
@bedevere-app bedevere-app bot mentioned this pull request Feb 11, 2024
Closed
terryjreedy
terryjreedy requested changes Feb 11, 2024
View reviewed changes
@bedevere-app
Copy link
bedevere-app bot commented Feb 11, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@sobolevn
Copy link
Member Author

Agreed, I just skip the test right now when there are no docstrings.

ericvsmith
ericvsmith approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member
@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sobolevn
Copy link
Member Author

Thanks everyone!

@sobolevn sobolevn merged commit 4297d73 into python:main Feb 12, 2024
@sobolevn sobolevn added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 12, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@sobolevn @miss-islington
pythongh-115285: Fix test_dataclasses with -OO mode (pythonGH-115286
2026d81 
)

(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115358 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@sobolevn @miss-islington
pythongh-115285: Fix test_dataclasses with -OO mode (pythonGH-115286
1597d7b 
)

(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 12, 2024
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115359 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 12, 2024
sobolevn added a commit that referenced this pull request Feb 12, 2024
@miss-islington @sobolevn
[3.11] gh-115285: Fix test_dataclasses with -OO mode ( 8000 GH-115286) (#…
d732134 
…115358)

gh-115285: Fix `test_dataclasses` with `-OO` mode (GH-115286)
(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Feb 12, 2024
@miss-islington @sobolevn
[3.12] gh-115285: Fix test_dataclasses with -OO mode (GH-115286) (#…
2ed47d8 
…115359)

gh-115285: Fix `test_dataclasses` with `-OO` mode (GH-115286)
(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@sobolevn @fsc-eriker
pythongh-115285: Fix test_dataclasses with -OO mode (python#115286)
b79bd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy requested changes

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @ericvsmith @terryjreedy @Eclips4
0